From 14c4101a039445d13dea03d2834e0caaee4dff99 Mon Sep 17 00:00:00 2001
From: fiatjaf <fiatjaf@gmail.com>
Date: Thu, 30 Jan 2025 16:07:20 -0300
Subject: [PATCH] nip60: Processed is also a function now.

---
 nip60/eventcodec_test.go | 11 -----------
 nip60/stash.go           | 37 ++++++++++++++++++++++++++-----------
 nip60/wallet_test.go     | 18 ------------------
 3 files changed, 26 insertions(+), 40 deletions(-)

diff --git a/nip60/eventcodec_test.go b/nip60/eventcodec_test.go
index bda09a3..2b6b68d 100644
--- a/nip60/eventcodec_test.go
+++ b/nip60/eventcodec_test.go
@@ -151,19 +151,8 @@ func TestWalletRoundtrip(t *testing.T) {
 		// load wallets from events
 		walletStash := loadStash(ctx, kr, eventChan, make(chan struct{}))
 
-		var errorChanErr error
-		go func() {
-			for {
-				errorChanErr = <-walletStash.Processed
-				if errorChanErr != nil {
-					return
-				}
-			}
-		}()
-
 		<-done
 		time.Sleep(time.Millisecond * 200)
-		require.NoError(t, errorChanErr, "errorChan shouldn't have received any errors: %w", errorChanErr)
 
 		// compare loaded wallets with original ones
 		loadedWallet1 := walletStash.wallets[wallet1.Identifier]
diff --git a/nip60/stash.go b/nip60/stash.go
index ece7d93..583c113 100644
--- a/nip60/stash.go
+++ b/nip60/stash.go
@@ -32,8 +32,8 @@ type WalletStash struct {
 		isHistory bool,
 	)
 
-	// Processed emits an error or nil every time an event is processed
-	Processed chan error
+	// Processed, if not nil, is called every time a received event is processed
+	Processed func(*nostr.Event, error)
 
 	// Stable is closed when we have gotten an EOSE from all relays
 	Stable chan struct{}
@@ -100,7 +100,6 @@ func loadStash(
 		pendingHistory:   make(map[string][]HistoryEntry),
 		pendingDeletions: make([]string, 0, 128),
 		kr:               kr,
-		Processed:        make(chan error),
 		Stable:           make(chan struct{}),
 	}
 
@@ -138,8 +137,10 @@ func loadStash(
 					wl: wl,
 				}
 				if err := wallet.parse(ctx, kr, ie.Event); err != nil {
+					if wl.Processed != nil {
+						wl.Processed(ie.Event, err)
+					}
 					wl.Unlock()
-					wl.Processed <- fmt.Errorf("event %s failed: %w", ie.Event, err)
 					continue
 				}
 
@@ -182,21 +183,27 @@ func loadStash(
 			case 7375: // token
 				ref := ie.Event.Tags.GetFirst([]string{"a", ""})
 				if ref == nil {
+					if wl.Processed != nil {
+						wl.Processed(ie.Event, fmt.Errorf("event missing 'a' tag"))
+					}
 					wl.Unlock()
-					wl.Processed <- fmt.Errorf("event %s missing 'a' tag", ie.Event)
 					continue
 				}
 				spl := strings.SplitN((*ref)[1], ":", 3)
 				if len(spl) < 3 {
+					if wl.Processed != nil {
+						wl.Processed(ie.Event, fmt.Errorf("event with invalid 'a' tag"))
+					}
 					wl.Unlock()
-					wl.Processed <- fmt.Errorf("event %s invalid 'a' tag", ie.Event)
 					continue
 				}
 
 				token := Token{}
 				if err := token.parse(ctx, kr, ie.Event); err != nil {
+					if wl.Processed != nil {
+						wl.Processed(ie.Event, err)
+					}
 					wl.Unlock()
-					wl.Processed <- fmt.Errorf("event %s failed: %w", ie.Event, err)
 					continue
 				}
 
@@ -226,21 +233,27 @@ func loadStash(
 			case 7376: // history
 				ref := ie.Event.Tags.GetFirst([]string{"a", ""})
 				if ref == nil {
+					if wl.Processed != nil {
+						wl.Processed(ie.Event, fmt.Errorf("event missing 'a' tag"))
+					}
 					wl.Unlock()
-					wl.Processed <- fmt.Errorf("event %s missing 'a' tag", ie.Event)
 					continue
 				}
 				spl := strings.SplitN((*ref)[1], ":", 3)
 				if len(spl) < 3 {
+					if wl.Processed != nil {
+						wl.Processed(ie.Event, fmt.Errorf("event with invalid 'a' tag"))
+					}
 					wl.Unlock()
-					wl.Processed <- fmt.Errorf("event %s invalid 'a' tag", ie.Event)
 					continue
 				}
 
 				he := HistoryEntry{}
 				if err := he.parse(ctx, kr, ie.Event); err != nil {
+					if wl.Processed != nil {
+						wl.Processed(ie.Event, err)
+					}
 					wl.Unlock()
-					wl.Processed <- fmt.Errorf("event %s failed: %w", ie.Event, err)
 					continue
 				}
 
@@ -255,7 +268,9 @@ func loadStash(
 				}
 			}
 
-			wl.Processed <- nil
+			if wl.Processed != nil {
+				wl.Processed(ie.Event, nil)
+			}
 			wl.Unlock()
 		}
 	}()
diff --git a/nip60/wallet_test.go b/nip60/wallet_test.go
index 46cb417..a0e2fd8 100644
--- a/nip60/wallet_test.go
+++ b/nip60/wallet_test.go
@@ -57,24 +57,6 @@ func TestWalletTransfer(t *testing.T) {
 		pool.PublishMany(ctx, testRelays, event)
 	}
 
-	// handle events from both stashes
-	go func() {
-		for {
-			select {
-			case err := <-stash1.Processed:
-				if err != nil {
-					t.Errorf("stash1 processing error: %v", err)
-				}
-			case err := <-stash2.Processed:
-				if err != nil {
-					t.Errorf("stash2 processing error: %v", err)
-				}
-			case <-ctx.Done():
-				return
-			}
-		}
-	}()
-
 	// wait for initial load
 	select {
 	case <-stash1.Stable: