coracle/caravel
1
1
Fork 2
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(frontend): handle bolt11 generation failures in payment dialog #11

Merged
hodlbod merged 1 commits from userAdityaa/caravel:payment-dialog into master 2026-04-14 23:35:14 +00:00
Conversation 1 Commits 1 Files Changed 1
+55 -25
userAdityaa commented 2026-04-14 23:32:36 +00:00
Contributor
Copy Link
Copy Source

PR description:

Problem

  • When the payment dialog opened, bolt11 request failures were silently swallowed.
  • The dialog could remain stuck on Generating invoice with no actionable error or retry path.

Solution

  • Track bolt11 request state explicitly (idle/loading/ready/error)
  • Surface API errors with cause text and Retry action
  • Disable Complete Payment until invoice is ready
  • Preserve escape actions (Pay Later/close)

Validation

  • loading shown during request
  • error shown on bolt11 failure
  • retry available and functional
  • success flow unchanged once invoice is ready

closes #9

### PR description: **Problem** * When the payment dialog opened, bolt11 request failures were silently swallowed. * The dialog could remain stuck on Generating invoice with no actionable error or retry path. ### Solution * Track bolt11 request state explicitly (idle/loading/ready/error) * Surface API errors with cause text and Retry action * Disable Complete Payment until invoice is ready * Preserve escape actions (Pay Later/close) ### Validation * loading shown during request * error shown on bolt11 failure * retry available and functional * success flow unchanged once invoice is ready <video src="attachments/22c2dfda-82af-444a-b1a2-7bc09220d386" title="Screen Recording 2026-04-15 at 5.12.20 AM.mov" controls></video> closes #9
Screen Recording 2026-04-15 at 5.12.20 AM.mov
6.2 MiB
userAdityaa added 1 commit 2026-04-14 23:32:36 +00:00
feat(frontend): handle bolt11 generation failures in payment dialog 5849517a41
userAdityaa commented 2026-04-14 23:33:11 +00:00
Author
Contributor
Copy Link
Copy Source

@hodlbod, I went through the entire flow, it looks good and is ready to be merged.

@hodlbod, I went through the entire flow, it looks good and is ready to be merged.
hodlbod merged commit 072031d0c3 into master 2026-04-14 23:35:14 +00:00
userAdityaa deleted branch payment-dialog 2026-04-15 07:01:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/caravel#11
Delete Branch "userAdityaa/caravel:payment-dialog"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?