coracle/caravel
1
1
Fork 2
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

Improve Stripe error mapping for invoice fetches #15

New Issue
Closed
opened 2026-04-15 13:51:42 +00:00 by userAdityaa · 0 comments
userAdityaa commented 2026-04-15 13:51:42 +00:00
Contributor
Copy Link
Copy Source

Problem

Invoice fetch failures from Stripe are currently surfaced as internal server errors. A missing invoice, permission issue, or other 4xx from Stripe is collapsed into a generic 500, which makes the API response misleading and harder for clients to handle correctly.

Current behavior

  • Billing::stripe_get_invoice calls Stripe and uses error_for_status()
  • Any non-2xx Stripe response becomes an error
  • api::get_invoice converts that error into ApiError::Internal
  • Clients receive a 500 even when Stripe returned a 404 or another client-relevant status

Expected behavior

  • Stripe 404 for a missing invoice should return a not-found response
  • Other Stripe 4xx responses should be mapped to an appropriate client error
  • Only unexpected failures should become 500s
### Problem Invoice fetch failures from Stripe are currently surfaced as internal server errors. A missing invoice, permission issue, or other 4xx from Stripe is collapsed into a generic 500, which makes the API response misleading and harder for clients to handle correctly. ### Current behavior - `Billing::stripe_get_invoice` calls Stripe and uses `error_for_status()` - Any non-2xx Stripe response becomes an error - `api::get_invoice` converts that error into `ApiError::Internal` - Clients receive a 500 even when Stripe returned a 404 or another client-relevant status ### Expected behavior - Stripe 404 for a missing invoice should return a not-found response - Other Stripe 4xx responses should be mapped to an appropriate client error - Only unexpected failures should become 500s
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/caravel#15
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?