coracle/caravel
1
1
Fork 2
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

Subdomain validation has no length limit and allows reserved names #37

New Issue
Closed
opened 2026-04-20 12:36:22 +00:00 by userAdityaa · 0 comments
userAdityaa commented 2026-04-20 12:36:22 +00:00
Contributor
Copy Link
Copy Source

prepare_relay in api.rs only validates that subdomain characters match [a-z0-9-], but it misses key constraints: it doesn’t enforce length limits, block reserved names like api or admin, or reject invalid DNS labels with leading/trailing hyphens.

`prepare_relay` in `api.rs` only validates that subdomain characters match `[a-z0-9-]`, but it misses key constraints: it doesn’t enforce length limits, block reserved names like `api` or `admin`, or reject invalid DNS labels with leading/trailing hyphens. <video src="attachments/5e1c3d1a-125c-4d3c-844e-be4fef3b5fc4" title="Screen Recording 2026-04-20 at 6.19.52 PM.mp4" controls></video>
Screen Recording 2026-04-20 at 6.19.52 PM.mp4
433 KiB
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/caravel#37
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?