chore: prevent duplicate Lightning charges by adding durable invoice-level NWC payment guard #51

2026-04-25T11:23:25Z

userAdityaa commented

2026-04-25 11:23:25 +00:00

Summary

This PR fixes a critical billing risk where Stripe webhook retries could trigger multiple NWC payment attempts for the same Stripe invoice. The fix introduces a durable invoice-level NWC payment state guard in SQLite and routes both invoice.created and outstanding-invoice NWC flows through it.

Problem

NWC payment was attempted first, then Stripe invoice was marked paid out-of-band. If Stripe marking failed, webhook handling failed and retries could re-enter payment logic without durable invoice-level protection.

Why this fixes the issue

Stripe retrying the same invoice can no longer create a second Lightning charge attempt for that invoice because the persisted guard blocks reattempts once the invoice is in pending or paid state, and paid state is reused for Stripe reconciliation.

closes #50

### Summary This PR fixes a critical billing risk where Stripe webhook retries could trigger multiple NWC payment attempts for the same Stripe invoice. The fix introduces a durable invoice-level NWC payment state guard in SQLite and routes both invoice.created and outstanding-invoice NWC flows through it. ### Problem NWC payment was attempted first, then Stripe invoice was marked paid out-of-band. If Stripe marking failed, webhook handling failed and retries could re-enter payment logic without durable invoice-level protection. ### Why this fixes the issue Stripe retrying the same invoice can no longer create a second Lightning charge attempt for that invoice because the persisted guard blocks reattempts once the invoice is in pending or paid state, and paid state is reused for Stripe reconciliation. closes #50

userAdityaa added 1 commit 2026-04-25 11:23:25 +00:00

chore: prevent duplicate Lightning charges by adding durable invoice-level NWC payment guard d9c7e0c1e4

hodlbod added 1 commit 2026-04-25 13:02:49 +00:00

Merge branch 'master' into prevent-duplicate-lightning b325d62f5d

hodlbod merged commit 3ecd285290 into master

2026-04-25 13:02:56 +00:00

hodlbod referenced this issue from a commit

2026-04-25 13:02:58 +00:00

chore: prevent duplicate Lightning charges by adding durable invoice-level NWC payment guard (#51)

Sign in to join this conversation.