coracle/caravel
1
1
Fork 2
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

NWC wallet connection secrets are stored in plaintext #57

New Issue
Closed
opened 2026-05-01 10:43:53 +00:00 by userAdityaa · 3 comments
userAdityaa commented 2026-05-01 10:43:53 +00:00
Contributor
Copy Link
Copy Source

NWC secrets are stored in the tenant table as a plain text column and passed through model/query/command layers without encryption.

Billing consumes the same value directly to execute NWC payment operations.

NWC secrets are stored in the tenant table as a plain text column and passed through model/query/command layers without encryption. Billing consumes the same value directly to execute NWC payment operations.
userAdityaa commented 2026-05-01 16:28:49 +00:00
Author
Contributor
Copy Link
Copy Source

I believe PR #54 and this issue are the final priority items before launch. Once both are resolved, I’ll do a thorough cleanup and final verification pass.

once #54 is merged, I will move on with the fix for this.

I believe PR #54 and this issue are the final priority items before launch. Once both are resolved, I’ll do a thorough cleanup and final verification pass. once #54 is merged, I will move on with the fix for this.
userAdityaa commented 2026-05-02 12:45:51 +00:00
Author
Contributor
Copy Link
Copy Source

@hodlbod, I’ve pushed the changes for this issue. From my side, this looks like the last launch-critical blocker. It would be great if you could also verify it. After that, I’ll shift my focus back to flotilla to work on my assigned issues.

@hodlbod, I’ve pushed the changes for this issue. From my side, this looks like the last launch-critical blocker. It would be great if you could also verify it. After that, I’ll shift my focus back to flotilla to work on my assigned issues.
hodlbod commented 2026-05-02 14:23:20 +00:00
Owner
Copy Link
Copy Source

Great, just a few comments. I'll try to test caravel with stripe keys and everything this week

Great, just a few comments. I'll try to test caravel with stripe keys and everything this week
❤️ 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/caravel#57
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?