From 19f657e348294b07bcf5ead5bf9716e2bce8388f Mon Sep 17 00:00:00 2001
From: Jon Staab <shtaab@gmail.com>
Date: Thu, 6 Feb 2025 11:33:01 -0800
Subject: [PATCH] Make sharing indicator nicer

---
 CHANGELOG.md                                  |  2 +-
 src/app/components/ChannelCompose.svelte      |  8 +-----
 .../components/ChannelComposeParent.svelte    | 13 ++++++----
 src/app/components/Chat.svelte                | 11 ++++++--
 src/app/components/Content.svelte             |  6 +++--
 src/app/components/ContentQuote.svelte        | 12 +++++++--
 src/app/components/EventShare.svelte          |  8 +-----
 src/routes/spaces/[relay]/[room]/+page.svelte | 26 ++++++++++++++++---
 8 files changed, 56 insertions(+), 30 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 860a5e34..79221606 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,7 +6,7 @@
 * Migrate to svelte 5 (fixes some bugs, probably introduces others)
 * Migrate to new welshman editor
 * Make reply indicator nicer
-* (pending) Make share indicator nicer
+* Make share indicator nicer
 * Improve feed loading
 * (pending) Show marker for last activity in chat
 
diff --git a/src/app/components/ChannelCompose.svelte b/src/app/components/ChannelCompose.svelte
index d826c0fd..4a69d06e 100644
--- a/src/app/components/ChannelCompose.svelte
+++ b/src/app/components/ChannelCompose.svelte
@@ -1,5 +1,4 @@
 <script lang="ts">
-  import {onMount} from "svelte"
   import {writable} from "svelte/store"
   import {isMobile, preventDefault} from "@lib/html"
   import Icon from "@lib/components/Icon.svelte"
@@ -9,10 +8,9 @@
 
   interface Props {
     onSubmit: any
-    content?: string
   }
 
-  const {onSubmit, content = ""}: Props = $props()
+  const {onSubmit}: Props = $props()
 
   const autofocus = !isMobile
 
@@ -36,10 +34,6 @@
   }
 
   const editor = makeEditor({autofocus, submit, uploading, aggressive: true})
-
-  onMount(() => {
-    editor.chain().setContent(content).run()
-  })
 </script>
 
 <form class="relative z-feature flex gap-2 p-2" onsubmit={preventDefault(submit)}>
diff --git a/src/app/components/ChannelComposeParent.svelte b/src/app/components/ChannelComposeParent.svelte
index 85337c35..a18718d6 100644
--- a/src/app/components/ChannelComposeParent.svelte
+++ b/src/app/components/ChannelComposeParent.svelte
@@ -6,18 +6,21 @@
   import Button from "@lib/components/Button.svelte"
   import Content from "@app/components/Content.svelte"
 
-  interface Props {
+  const {
+    verb,
+    event,
+    clear,
+  }: {
+    verb: string
     event: TrustedEvent
     clear: () => void
-  }
-
-  const {event, clear}: Props = $props()
+  } = $props()
 </script>
 
 <div
   class="relative border-l-2 border-solid border-primary bg-base-300 px-2 py-1 pr-8 text-xs"
   transition:slide>
-  <p class="text-primary">Replying to @{displayProfileByPubkey(event.pubkey)}</p>
+  <p class="text-primary">{verb} @{displayProfileByPubkey(event.pubkey)}</p>
   {#key event.id}
     <Content {event} hideMedia minLength={100} maxLength={300} expandMode="disabled" />
   {/key}
diff --git a/src/app/components/Chat.svelte b/src/app/components/Chat.svelte
index f75d1011..4efdb8b7 100644
--- a/src/app/components/Chat.svelte
+++ b/src/app/components/Chat.svelte
@@ -1,4 +1,5 @@
 <script lang="ts">
+  import type {Snippet} from "svelte"
   import {onMount} from "svelte"
   import {int, nthNe, MINUTE, sortBy, remove} from "@welshman/lib"
   import type {TrustedEvent, EventContent} from "@welshman/util"
@@ -28,7 +29,13 @@
   import {pushModal} from "@app/modal"
   import {sendWrapped, prependParent} from "@app/commands"
 
-  const {id, info = undefined} = $props()
+  const {
+    id,
+    info,
+  }: {
+    id: string
+    info?: Snippet
+  } = $props()
 
   const chat = deriveChat(id)
   const pubkeys = splitChatId(id)
@@ -205,7 +212,7 @@
     </p>
   </div>
   {#if parent}
-    <ChatComposeParent event={parent} clear={clearParent} />
+    <ChatComposeParent event={parent} clear={clearParent} verb="Replying to" />
   {/if}
   <ChatCompose bind:this={compose} {onSubmit} />
 </div>
diff --git a/src/app/components/Content.svelte b/src/app/components/Content.svelte
index b4b35991..e72ecc69 100644
--- a/src/app/components/Content.svelte
+++ b/src/app/components/Content.svelte
@@ -115,6 +115,8 @@
   const hasEllipsis = $derived(shortContent.some(isEllipsis))
   const expandInline = $derived(hasEllipsis && expandMode === "inline")
   const expandBlock = $derived(hasEllipsis && expandMode === "block")
+
+  $inspect(fullContent)
 </script>
 
 <div class="relative">
@@ -131,8 +133,8 @@
       class="overflow-hidden text-ellipsis break-words"
       style={expandBlock ? "mask-image: linear-gradient(0deg, transparent 0px, black 100px)" : ""}>
       {#each shortContent as parsed, i}
-        {#if isNewline(parsed)}
-          <ContentNewline value={parsed.value.slice(isBlock(i - 1) ? 1 : 0)} />
+        {#if isNewline(parsed) && !isBlock(i - 1)}
+          <ContentNewline value={parsed.value} />
         {:else if isTopic(parsed)}
           <ContentTopic value={parsed.value} />
         {:else if isCode(parsed)}
diff --git a/src/app/components/ContentQuote.svelte b/src/app/components/ContentQuote.svelte
index d01c69ed..822163b9 100644
--- a/src/app/components/ContentQuote.svelte
+++ b/src/app/components/ContentQuote.svelte
@@ -3,12 +3,12 @@
   import {goto} from "$app/navigation"
   import {ctx, nthEq} from "@welshman/lib"
   import {tracker, repository} from "@welshman/app"
-  import {Address, DIRECT_MESSAGE, MESSAGE, THREAD} from "@welshman/util"
+  import {Address, DIRECT_MESSAGE, MESSAGE, THREAD, EVENT_TIME} from "@welshman/util"
   import Button from "@lib/components/Button.svelte"
   import Spinner from "@lib/components/Spinner.svelte"
   import NoteCard from "@app/components/NoteCard.svelte"
   import {deriveEvent, entityLink, ROOM} from "@app/state"
-  import {makeThreadPath, makeRoomPath} from "@app/routes"
+  import {makeThreadPath, makeCalendarPath, makeRoomPath} from "@app/routes"
 
   const {value, event, noteContent, relays = [], minimal = false} = $props()
 
@@ -70,6 +70,10 @@
           return goto(makeThreadPath(url, $quote.id))
         }
 
+        if ($quote.kind === EVENT_TIME) {
+          return goto(makeCalendarPath(url, $quote.id))
+        }
+
         if ($quote.kind === MESSAGE) {
           return scrollToEvent($quote.id) || openMessage(url, room, $quote.id)
         }
@@ -82,6 +86,10 @@
             return goto(makeThreadPath(url, id))
           }
 
+          if (parseInt(kind) === EVENT_TIME) {
+            return goto(makeCalendarPath(url, id))
+          }
+
           if (parseInt(kind) === MESSAGE) {
             return scrollToEvent(id) || openMessage(url, room, id)
           }
diff --git a/src/app/components/EventShare.svelte b/src/app/components/EventShare.svelte
index 11f2f14e..3949e707 100644
--- a/src/app/components/EventShare.svelte
+++ b/src/app/components/EventShare.svelte
@@ -1,9 +1,6 @@
 <script lang="ts">
-  import {nip19} from "nostr-tools"
   import {goto} from "$app/navigation"
-  import {ctx} from "@welshman/lib"
   import type {TrustedEvent} from "@welshman/util"
-  import {toNostrURI} from "@welshman/util"
   import {preventDefault} from "@lib/html"
   import Icon from "@lib/components/Icon.svelte"
   import Button from "@lib/components/Button.svelte"
@@ -16,13 +13,10 @@
 
   const {url, noun, event}: {url: string; noun: string; event: TrustedEvent} = $props()
 
-  const relays = ctx.app.router.Event(event).getUrls()
-  const nevent = nip19.neventEncode({id: event.id, relays})
-
   const back = () => history.back()
 
   const onSubmit = () => {
-    setKey("content", toNostrURI(nevent))
+    setKey("share", event)
     goto(makeRoomPath(url, selection), {replaceState: true})
   }
 
diff --git a/src/routes/spaces/[relay]/[room]/+page.svelte b/src/routes/spaces/[relay]/[room]/+page.svelte
index 626cad73..9547e654 100644
--- a/src/routes/spaces/[relay]/[room]/+page.svelte
+++ b/src/routes/spaces/[relay]/[room]/+page.svelte
@@ -42,7 +42,6 @@
 
   const {room = GENERAL} = $page.params
   const lastChecked = $checked[$page.url.pathname]
-  const content = popKey<string>("content") || ""
   const url = decodeRelay($page.params.relay)
   const filter = {kinds: [MESSAGE], "#h": [room]}
   const relay = deriveRelay(url)
@@ -78,17 +77,32 @@
     parent = undefined
   }
 
+  const clearShare = () => {
+    share = undefined
+  }
+
   const onSubmit = ({content, tags}: EventContent) => {
     tags.push(tagRoom(room, url))
     tags.push(PROTECTED)
 
+    let template = {content, tags}
+
+    if (share) {
+      template = prependParent(share, template)
+    }
+
+    if (parent) {
+      template = prependParent(parent, template)
+    }
+
     publishThunk({
       relays: [url],
-      event: createEvent(MESSAGE, prependParent(parent, {content, tags})),
+      event: createEvent(MESSAGE, template),
       delay: $userSettingValues.send_delay,
     })
 
     clearParent()
+    clearShare()
   }
 
   const onScroll = () => {
@@ -113,6 +127,7 @@
   const scrollToBottom = () => element?.scrollTo({top: 0, behavior: "smooth"})
 
   let loading = $state(true)
+  let share = $state(popKey<TrustedEvent | undefined>("share"))
   let parent: TrustedEvent | undefined = $state()
   let element: HTMLElement | undefined = $state()
   let newMessages: HTMLElement | undefined = $state()
@@ -264,9 +279,12 @@
   {/if}
   <div class="saib">
     {#if parent}
-      <ChannelComposeParent event={parent} clear={clearParent} />
+      <ChannelComposeParent event={parent} clear={clearParent} verb="Replying to" />
     {/if}
-    <ChannelCompose bind:this={compose} {content} {onSubmit} />
+    {#if share}
+      <ChannelComposeParent event={share} clear={clearShare} verb="Sharing" />
+    {/if}
+    <ChannelCompose bind:this={compose} {onSubmit} />
   </div>
 </div>