Address RBAC review feedback

2026-04-18 01:39:54 +05:30
parent 559db6b930
commit 9756199fdf
12 changed files with 105 additions and 74 deletions
@@ -29,7 +29,13 @@
    deriveSpaceBannedPubkeyItems,
    deriveSupportedMethods,
  } from "@app/core/state"
-  import {deriveSpaceMemberRoleInfo, deriveUserHasSpacePermission} from "@app/core/roles"
+  import {
+    deriveSpaceMemberRoleInfo,
+    deriveUserHasSpacePermission,
+    ROOM_PERMISSION_ADD_MEMBER,
+    ROOM_PERMISSION_REMOVE_MEMBER,
+    ROOM_PERMISSION_BAN_USER,
+  } from "@app/core/roles"
  import {pushModal} from "@app/util/modal"
  import {pushToast} from "@app/util/toast"

@@ -42,9 +48,9 @@
  const members = deriveSpaceMembers(url)
  const bans = deriveSpaceBannedPubkeyItems(url)
  const spaceMemberRoles = deriveSpaceMemberRoleInfo(url)
-  const canAddMember = deriveUserHasSpacePermission(url, 9000)
-  const canBanByPermission = deriveUserHasSpacePermission(url, 9009)
-  const canUnallowByPermission = deriveUserHasSpacePermission(url, 9001)
+  const canAddMember = deriveUserHasSpacePermission(url, ROOM_PERMISSION_ADD_MEMBER)
+  const canBanByPermission = deriveUserHasSpacePermission(url, ROOM_PERMISSION_BAN_USER)
+  const canUnallowByPermission = deriveUserHasSpacePermission(url, ROOM_PERMISSION_REMOVE_MEMBER)
  const supportedMethods = deriveSupportedMethods(url)
  const canBan = $derived(
    $canBanByPermission && $supportedMethods.includes(ManagementMethod.BanPubkey),