coracle/flotilla
1
6
Fork 24
Code Issues 42 Pull Requests 2 Actions Packages Projects 5 Releases Wiki Activity

Expect pubkey in kind 39004 #101

Merged
hodlbod merged 1 commits from feature/98-expect-pubkey-in-room-presence into dev 2026-03-17 19:38:11 +00:00
Conversation 0 Commits 1 Files Changed 1
+6 -6
mplorentz commented 2026-03-17 18:56:48 +00:00
Collaborator
Copy Link
Copy Source

This adjusts our implementation of the Livekit presence event to match the NIP (https://github.com/nostr-protocol/nips/pull/2238#issuecomment-4057645310). Specifically we now expect the user's Nostr pubkey in the participant tag instead of the livekit identity string.

I also fixed a bug I found where a malformed participant tag would crash the rendering of VoiceWidget, causing it to appear frozen.

There is a corresponding zooid PR here

This adjusts our implementation of the Livekit presence event to match the NIP (https://github.com/nostr-protocol/nips/pull/2238#issuecomment-4057645310). Specifically we now expect the user's Nostr pubkey in the `participant` tag instead of the livekit identity string. I also fixed a bug I found where a malformed `participant` tag would crash the rendering of VoiceWidget, causing it to appear frozen. There is a corresponding zooid PR [here](https://github.com/coracle-social/zooid/pull/11)
mplorentz added 1 commit 2026-03-17 18:56:49 +00:00
Fix a rendering crash when relay put bad data in 39004. 4311bf6692
mplorentz marked the pull request as ready for review 2026-03-17 19:02:32 +00:00
mplorentz requested review from hodlbod 2026-03-17 19:02:37 +00:00
hodlbod merged commit 368f0b048b into dev 2026-03-17 19:38:11 +00:00
hodlbod deleted branch feature/98-expect-pubkey-in-room-presence 2026-03-17 19:38:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
hodlbod
Labels
Clear labels
design
For issues related to design work. Development should be done in another issue and refer back to this one.
 dev
Issues related to development work
 easy
Issues that can be executed on by new contributors
 idea
For issues that aren't yet actionable
 priority
For issues related to high priority features and bugs
 usability
Issues that have to be validated with real live human beings.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod) mplorentz (Matt Lorentz) sakshamjain (Saksham Jain) sondreb triesap userAdityaa (Aditya Chaudhary)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#101
Delete Branch "feature/98-expect-pubkey-in-room-presence"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?