coracle/flotilla
1
6
Fork 23
Code Issues 42 Pull Requests 2 Actions Packages Projects 5 Releases Wiki Activity

Change audio devices in call #112

Merged
hodlbod merged 2 commits from feature/98-audio-settings-in-call into dev 2026-04-02 19:33:49 +00:00
Conversation 2 Commits 2 Files Changed 3
+173
mplorentz commented 2026-04-01 18:25:19 +00:00
Collaborator
Copy Link
Copy Source

This adds a little settings icon in VoiceWidget that opens a dialog where you can change your audio input and output device.

Screenshot 2026-04-01 at 2.24.18 PM.png

This adds a little settings icon in VoiceWidget that opens a dialog where you can change your audio input and output device. ![Screenshot 2026-04-01 at 2.24.18 PM.png](/attachments/97ee113c-309f-4014-80f6-29003671bfc0)
Screenshot 2026-04-01 at 2.24.18 PM.png
89 KiB
hodlbod reviewed 2026-04-01 19:59:15 +00:00
src/app/components/VoiceCallAudioSettingsDialog.svelte Outdated
@@ -0,0 +50,4 @@
md.addEventListener("devicechange", onDeviceChange)
return () => {
md.removeEventListener("devicechange", onDeviceChange)
}
hodlbod commented 2026-04-01 19:54:51 +00:00
Owner
Copy Link
Copy Source

A less verbose version:

loadDevices()
navigator.mediaDevices?.addEventListener?.("devicechange", loadDevices)
return () => navigator.mediaDevices?.removeEventListener?.("devicechange", loadDevices)
A less verbose version: ``` loadDevices() navigator.mediaDevices?.addEventListener?.("devicechange", loadDevices) return () => navigator.mediaDevices?.removeEventListener?.("devicechange", loadDevices) ```
mplorentz commented 2026-04-02 19:19:27 +00:00
Author
Collaborator
Copy Link
Copy Source

ok yeah the AI was worried about keeping the linter happy because loadDevices returns a promise that we don't await, but it was hallucinating and I don't know enough to know better.

ok yeah the AI was worried about keeping the linter happy because loadDevices returns a promise that we don't await, but it was hallucinating and I don't know enough to know better.
hodlbod marked this conversation as resolved
src/app/voice.ts Outdated
@@ -46,0 +71,4 @@
case DeviceKind.AudioOutput:
label = "speaker"
break
}
hodlbod commented 2026-04-01 19:59:05 +00:00
Owner
Copy Link
Copy Source

why not const label = kind === DeviceKind.AudioInput ? "microphone" : "speaker"

why not `const label = kind === DeviceKind.AudioInput ? "microphone" : "speaker"`
mplorentz commented 2026-04-02 19:20:32 +00:00
Author
Collaborator
Copy Link
Copy Source

Mostly because I'm adding DeviceKind.VideoInput in another branch.

Mostly because I'm adding `DeviceKind.VideoInput` in another branch.
hodlbod marked this conversation as resolved
hodlbod commented 2026-04-01 19:59:57 +00:00
Owner
Copy Link
Copy Source

Looks pretty good, maybe use ModalSubtitle for the "choose microphone" text, and make Done full width for consistency

Looks pretty good, maybe use ModalSubtitle for the "choose microphone" text, and make `Done` full width for consistency
mplorentz requested review from hodlbod 2026-04-02 19:28:23 +00:00
hodlbod added 2 commits 2026-04-02 19:33:41 +00:00
Add settings button to configure audio devices in call 0ef6052820
PR fixes 617b5c9fca
hodlbod force-pushed feature/98-audio-settings-in-call from 666351bf4f to 617b5c9fca 2026-04-02 19:33:41 +00:00 Compare
hodlbod merged commit 61ed632579 into dev 2026-04-02 19:33:49 +00:00
hodlbod deleted branch feature/98-audio-settings-in-call 2026-04-02 19:33:49 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
hodlbod
Labels
Clear labels
design
For issues related to design work. Development should be done in another issue and refer back to this one.
 dev
Issues related to development work
 easy
Issues that can be executed on by new contributors
 idea
For issues that aren't yet actionable
 priority
For issues related to high priority features and bugs
 usability
Issues that have to be validated with real live human beings.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod) mplorentz (Matt Lorentz) sakshamjain (Saksham Jain) sondreb triesap userAdityaa (Aditya Chaudhary)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#112
Delete Branch "feature/98-audio-settings-in-call"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?