fix: respect VITE_PLATFORM_LOGO with fallback #116
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coracle/flotilla#116
Reference in New Issue
Block a user
Delete Branch "nayan9617/flotilla:fix/platform-logo-env"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
This PR fixes a platform customization gap where VITE_PLATFORM_LOGO was documented but not used at runtime.
Addresses #115
Why
Custom deployments are expected to override the app logo through environment config, but the app currently hardcodes the logo path from PLATFORM_URL.
That creates a mismatch between documented behavior and actual behavior.
What changed
Updated platform logo resolution in state.ts:194:
Use VITE_PLATFORM_LOGO when provided
Keep existing fallback to PLATFORM_URL + /logo.png
Added a clarifying note in .env.template:8:
VITE_PLATFORM_LOGO can be either a local path (for example logo.png) or a full HTTPS URL
Backward compatibility
No breaking change.
If VITE_PLATFORM_LOGO is not set, behavior remains the same as before.
Validation
Synced branch with latest origin/dev before push
Ran lint successfully
Ran type checks successfully (0 errors, 0 warnings)
Notes
This is a small quality fix that aligns runtime behaviour with configuration and deployment docs.
VITE_PLATFORM_LOGO is used, but only for production builds. The build script downloads the url, then processes it so that it's used as the favicon etc as well as just the platform logo. Maybe what you could do is check whether this is a production build in state.ts — if it is, always use logo.png; otherwise use VITE_PLATFORM_LOGO.
Totally fair, thanks for flagging it.
I’ll update it so production always uses logo.png (to match the build pipeline), and only use VITE_PLATFORM_LOGO in dev/non-production for local customization.
dade83d5deto4f7aa19166