Room Invites #118
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coracle/flotilla#118
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Looks pretty simple, just a create invite code and a code tag on join-room:
https://github.com/nostr-protocol/nips/blob/master/29.md
This will have to be combined with room invite codes. Probably the best thing to do for a first pass would be to add a "create invite" option to the RoomDetail menu which creates the same kind of link we create for the space invite, but with both a space and a room invite code included. This code will have to be used when joining rooms explicitly, but also parsed and used when joining spaces.
Related: https://github.com/coracle-social/zooid/issues/12
Room invite codesto Design oom invite codesDesign oom invite codesto Design Room InvitesDesign Room Invitesto Room InvitesHi @hodlbod, I have understood this issue and have a clear picture of how to design this.
Just wanted to clarify two things:
If this aligns, I’d like to work on this. Could you assign this issue to me?
Thanks
1 — yes, all invites should include a space url and claim, as well as optionally an
hand acodefor the room invite.2 — yes, invite links should be clickable from within flotilla. I believe this already exists in the form of navigating to the room and opening the join dialog with the invite url populated. The history gets a little goofy though, so special casing it might be an improvement.
Hi @hodlbod ,
I am done with a preliminary iteration of this design. Currently, I have worked on the flow, main high-fidelity mockup screens and a minimal prototype.
Figma Link - https://www.figma.com/design/GkkFIIOBqEquBpqPMnRFB7/Flotilla-Design---Saksham-Jain?node-id=0-1&t=RBMP6dGduIszWsCC-1
Prototype Link - https://www.figma.com/proto/GkkFIIOBqEquBpqPMnRFB7/Flotilla-Design---Saksham-Jain?page-id=0%3A1&node-id=1-3&viewport=392%2C545%2C0.17&t=Fr6uAHoxKx6OnVkJ-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=1%3A3
After your feedback, I will finalise the flow and then design the following parts.
Glimpse:
Currently, my approach has been to make it as functional and as similar to the existing design as possible. There are a lot of improvements that could be done in terms of UI/UX and usability enhancement, but that would lead to an overhaul of the Room details modal. Do let me know if you would want me to work on that as well.
Right now the members list has an "Add members" button on the member list. Would you suggest keeping that or removing it and replacing it with this new dialog? It seems odd to have it in two places, although I've noticed in practice the current placement is unwieldy. I do like the "Create invite" button being inline on the room form.
This button is not visible for regular users, It would be really helpful if you can also share a snippet how the current "Add members" list looks.
We can actually keep both functionalities, since both of them have slight variations in their working:
Sure, attached is what the current add members stuff looks like.
For inviting via DM, I think we should validate that with users first by doing usability testing with invites. So let's leave it out for now. However, it occurs to me it might be helpful to have a share button here which invokes the native share dialog on Android/iOS. Want to take a look at adding that?
Got it, that makes sense.
Just to confirm, the idea is to add a Share button that triggers the native share dialog on mobile (Android/iOS), with the invite link pre-filled so users can share it across other apps like WhatsApp, Messages, etc., right?
Secondly, should the placement of that button be inside the "Create a Room Invite" modal I am currently designing?
Yep!
Yes, but I'm not sure exactly how it should be done. A good starting point would be to add a share button to SpaceInvite somewhere, and then copy that dialog for the RoomInvite. Feel free to make multiple design passes to fail left/right and experiment with different approaches.
Understood. I will share the iterations with you today.
What are your opinions on these:
I found these to be clean iterations. I can share more approaches as well.
Looks good, I think I prefer the one with the share button on the right. Did you want to implement this as well?
I’d love to implement this. Although I haven’t worked with native Android/iOS environments before, I do have a strong background in web development.
I’m open to giving it a try with some guidance, or starting with a simpler version / one platform first.
Since I’m primarily in the design track for Summer of Bitcoin, I just wanted to check what you’d prefer.
This shouldn't be too hard, you can use https://capacitorjs.com/docs/apis/share and it should work the same way everywhere. Feel free to just test on web and I can test on ios/android, but it also isn't difficult to test using an emulator. Just do
pnpm buildand then run the project in android studio or xcode. Up to you though. Let me know if you'd like to try developing, or we can leave this to another contributor.Thanks for the guidance, this makes sense.
I’d be happy to take this on. Since this can be handled via Capacitor, I’ll start with the web implementation using the Share API, and we can test it across platforms after.
Hi @hodlbod,
I had implemented this functionality via Capacitor earlier, and it’s working as expected on the web.
However, while testing on Android (via Android Studio), I’m consistently facing an issue where the rest of the app works, but the Space screen renders completely blank.
I’ve spent the last couple of days debugging this and tried multiple approaches:
At this point, I’m not sure if the issue is:
Sharing a short video for reference.
Would really appreciate your guidance on whether:
Thanks!
This looks good, I think the blank spaces issue is a regression from last week; I pushed a fix in
c740bd21d4