Refine search #141
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This covers room, recent activity, and dedicated search.
Hi @hodlbod can i work on this
Hi @hodlbod , I’ve gone through the issue and have a clear approach in mind.
Plan:
Replace heavy cards with a compact, scannable list layout
Create a reusable SearchResultItem for consistency
Adding a proper loading state (spinner + skeletons)
Improve empty state with centered, helpful messaging
If this aligns, I’d love to take this up. Could you assign this issue to me?
Thanks!
Sure @somnath, go ahead. @rajanarahul93 would you mind picking another issue?
@hodlbod sure
Hey @hodlbod there are a lot of issues i have identified in the search flow apart from the one you have mentioned but before that i want to clarify one thing currently search is implemented in only 2 places in the app right?
We can't see the person who has typed the message in the group during search also, which is a bad UX because sometimes people will not remember the message but the person only.
@hodlbod Also what are your thoughts on giving a universal search option for the space itself and using filters the user can navigate and search in any room he wants ?
Yeah, showing the author of the note would be helpful. Maybe use NoteContentMinimal for the note content. There are three search areas: global, room, and recent. The recent search is behind a search icon button in the header, see below.
For space search, the recent activity search covers that (although it's not very discoverable). It should also be covered by the global search. So we can skip it for now, but it's definitely an item for future usability testing.
Thanks for clarification, although its not showing me on my recent activity tab for some reason.
Regardless I'll start working on the global and room one.
Have you fetched from the dev branch recently?
No, I haven’t pulled from the dev branch recently. This is based on the main branch that’s currently live.
Pull the latest changes from the dev branch and rebase your branch on top of it; the changes should appear afterward.
Hey @somnath, are you still working on this? If not, I’d be happy to help out.
Sorry, I’m having a bit of trouble understanding this image, it appears quite blurry. Could you clarify what it’s meant to represent, or if it’s a design?
Hey @userAdityaa Thanks for asking, don't worry i am still working on it, the image above is just the current flow of people search in the app, i am currently making mockups for all search functionality in the app.
I will share the figma file and screenshot of the User flow of searching for all the cases once i am done.
Sry for the delay, health was a bit down.
No worries at all, thanks for the update. Take your time and focus on getting better first 😊
Hello @hodlbod i am done with the searching flow for spaces and people i have included the entire flow in the "✅Final Design page " of the below figma file.
https://www.figma.com/design/gK34wyCqRK5YtgKNYo51Rp/Flotilla-Design-Improvements?node-id=69-2748&t=dz35WmK9WEQ0644n-1
Check it out and let me know if something is unclear or if i missed something, I am up for some feedback.
Wow, these designs look really solid to me.
This looks pretty good. A couple comments:
I have edited the Figma file and made the necessary changes. Working on the mobile view, you can check on the same Figma and verify once.
https://www.figma.com/design/gK34wyCqRK5YtgKNYo51Rp/Flotilla-Design-Improvements?node-id=69-2748&t=wSBRh6ZSZHBBjZJj-1
@hodlbod What all content types can we add? Currently, we have 4 image video links and a file.
We could potentially search for polls, threads, calendar events, zap goals, chat, and classifieds as content types, although that's slightly different from the ones currently listed.
Scoping people search to spaces might not make sense, since people can cross space boundaries. But when searching in a space, it probably makes sense to weight people results by membership. Something still doesn't quite feel right about the distinction/commonality between global search, space search, and room search.
Here's an idea: always show search in the sidebar view. Depending on how the user opens this search view (room/space/global), we could pre-populate filters, and the user could then remove them if they want to broaden the search. This would unify 3+ search interfaces into a single location.
Got it @hodlbod I think i got a great idea till now ill explain the current scenario and future plan of how to approach this.
(Of course we can add filters here about searching in a particular space, of a particular room also, Finding messages and media etc from the entire app) - It will be very usefull for power users who are in more than 20 to 30 spaces inside flotilla and a scenario arises when he need to find "The xyz file from the entire app, but can't able to recall which space?"
i. We can remove the search icon from the bottom left and add that on the top of the page so that user knows that he was searching the entire flotilla interface including all the spaces and etc. (similar approach how slack has done) As you can see in the below screen shot 2 search icon clearly distinctable for 2 different use cases.
So in conclusion, i disagree a bit that we should unify Global app search interface with the space search, It will create un-necessary confusion to the user, he has to dig down into applying and removing a lot of filters which will in general increase the no of clicks and user will frustrate.
I think there needs to be 2 search icons shown in the UI And making it ovious to the user which search icon is for which kind of search.
I understand what you're saying, and it may be necessary, but it introduces visual clutter, which is something I want to avoid in flotilla if at all possible. I've also experienced confusion myself when deciding which search function to use. Having a single one would reduce that. We could pre-fill space filters depending on context with prompts to remove them if stuff from other spaces matched. This is implicit behavior, so a little risky, but could work really well. Probably something to usability test.
@hodlbod Fair enough Got it ! I'll revamp it then keep a single unified search i have few ideas for it...may be we can go with a Top long search bar attached with the whole app. The search UI should feel like separated from the main UI Elements so that user will know that you can search anything in the UI using the one search bar
I like the currently no-top-nav style, and I like what you've done with the search sidebar, maybe we could keep the search icon where it currently is and show search results in the sidebar or a dialog.
Got it! Working on it