73-video-thumbnails #142
Reference in New Issue
Block a user
Delete Branch "priyanshu_bharti/flotilla:73-video-thumbnails"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR implements video thumbnails for
.mov,.webm, and.mp4files in theContentLinkBlockcomponent.Changes:
posterattribute to the<video>tag.{url}#t=1to capture a clear preview frame at the 1-second mark.Closes #73
@priyanshu_bharti have you tested this on Android? I don't think it'll work there. Thumbnails work ok on web, but Android has a hard time with them. I think what we'll need to do is create a microservice that can be run independently and which can process video thumnails. We can then use an env var to request thumbnails from the service when the user is on android.
@hodlbod
Thank you for the detailed suggestion! ✅
I've implemented the video thumbnail microservice exactly as you mentioned so that it works independently and handles Android support properly.
feat: add video thumbnail microservice for Android support (#73)Thanks, this looks good! I've gone ahead and created a new repository for this project at https://gitea.coracle.social/coracle/vthumbs. Can you update this PR to just be the usage directions for flotilla, and do the following for the new repository:
@hodlbod
Thanks for creating the new repo!
I'll update this PR to only keep the usage instructions for flotilla.
Moving the microservice code to oracle/vthumbs and will add:
Dockerfile
Gitea build workflow
Updated README (removing flotilla references + environment config)
Will push the changes shortly. 👍
Hey @priyanshu_bharti are you still working on this? The diff only includes the env var and there aren't any open PRs on vthumbs
hii @hodlbod
Yes, I am working on it and raise the pr shortly under new repo
Hi @hodlbod ,
Done! ✅
Raised a complete PR in oracle/vthumbs repo with Dockerfile, Gitea workflow, and proper README.
Updated this Flotilla PR to keep only the usage instructions.
Please review both when possible.
Thanks! 👍
I know you had built an implementation which used the thumbnail service, but it looks like that's missing now, this is only a README update.
Hi @hodlbod , thanks for flagging this. You were right, I had accidentally force-pushed a README-only state. I have
now restored the Flotilla implementation that uses the thumbnail service on Android via VITE_THUMBNAIL_URL, and
this PR again contains the integration changes. I will handle the separate vthumbs repository updates in another PR.
Just tested this, it all works and looks good, the one thing that still needs to be done is to add caching to the vthumbs project. A plain in-memory cache with an expiration time of maybe 1 hour is fine for now. To cut down on memory requirements, you can set the quality of the thumbnail to something pretty conservative, maybe 65%.
I'll go ahead and merge this, go ahead and open a new PR on the vthumbs project.
075c2f4cb0tob8e949b1d4Thanks @hodlbod ,I will raise the PR for vthumbs soon when I am done.