coracle/flotilla
1
6
Fork 24
Code Issues 42 Pull Requests 2 Actions Packages Projects 5 Releases Wiki Activity

184-message-truncation #186

Merged
hodlbod merged 3 commits from priyanshu_bharti/flotilla:184-message-truncation into dev 2026-04-10 16:37:24 +00:00
Conversation 0 Commits 3 Files Changed 1
+8 -2
priyanshu_bharti commented 2026-04-10 15:25:21 +00:00
Contributor
Copy Link
Copy Source

Summary

This PR addresses #184 by increasing chat message truncation thresholds in room messages.
Long messages were being truncated too early with a See more button, which made normal reading annoying.

Changes

  1. Increased room-message truncation limits to:
    • minLength: 5000
    • maxLength: 5500
  2. Applied these limits consistently in both room message render paths:
    • linked room item view
    • inline/mobile room item view
  3. Kept default truncation behavior unchanged outside room chat scope.

Why

Issue #184 requested a much higher truncation threshold (around 5k) because early truncation is more annoying than helpful in chat.

Validation

  1. Lint passed.
  2. Type/check passed.
  3. Manual behavior verified:
    • messages below threshold render fully
    • very long messages still show See more/Read more as expected

Issue

Closes #184

## Summary This PR addresses #184 by increasing chat message truncation thresholds in room messages. Long messages were being truncated too early with a See more button, which made normal reading annoying. ## Changes 1. Increased room-message truncation limits to: - minLength: 5000 - maxLength: 5500 2. Applied these limits consistently in both room message render paths: - linked room item view - inline/mobile room item view 3. Kept default truncation behavior unchanged outside room chat scope. ## Why Issue #184 requested a much higher truncation threshold (around 5k) because early truncation is more annoying than helpful in chat. ## Validation 1. Lint passed. 2. Type/check passed. 3. Manual behavior verified: - messages below threshold render fully - very long messages still show See more/Read more as expected ## Issue Closes #184
Screencast from 2026-04-10 20-53-46.webm
9.8 MiB
hodlbod added 3 commits 2026-04-10 16:37:01 +00:00
feat(room-item): raise limits for linked messages 0ad5dea1df
feat(room-item): apply limits to inline messages c129bf70bc
refactor(room-item): name truncation thresholds 1116e74dd1
hodlbod force-pushed 184-message-truncation from c0706f9027 to 1116e74dd1 2026-04-10 16:37:01 +00:00 Compare
hodlbod merged commit 85c5293082 into dev 2026-04-10 16:37:24 +00:00
hodlbod deleted branch 184-message-truncation 2026-04-10 16:37:24 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
design
For issues related to design work. Development should be done in another issue and refer back to this one.
 dev
Issues related to development work
 easy
Issues that can be executed on by new contributors
 idea
For issues that aren't yet actionable
 priority
For issues related to high priority features and bugs
 usability
Issues that have to be validated with real live human beings.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod) mplorentz (Matt Lorentz) sakshamjain (Saksham Jain) sondreb triesap userAdityaa (Aditya Chaudhary)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#186
Delete Branch "priyanshu_bharti/flotilla:184-message-truncation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?