coracle/flotilla
1
6
Fork 24
Code Issues 42 Pull Requests 2 Actions Packages Projects 5 Releases Wiki Activity

fix: prevent redundant sync re-initialization on room navigation #193

Closed
rajanarahul93 wants to merge 1 commits from rajanarahul93/flotilla:fix/sync-space-reinit into dev
pull from: rajanarahul93/flotilla:fix/sync-space-reinit
merge into: coracle:dev
Conversation 1 Commits 1 Files Changed 1
+1
rajanarahul93 commented 2026-04-11 21:01:22 +00:00
First-time contributor
Copy Link
Copy Source

Summary:
Fixes redundant sync teardown and re-initialization when navigating between rooms.

Changes:

  • Removed room-based keying from syncSpaces
  • Sync now initializes once per space (URL-based)

Impact:

  • Prevents unnecessary CLOSE/REQ cycles
  • Reduces network churn and CPU overhead

Notes:
Duplicate listeners inside syncSpace were not modified, as they appear intentional due to relay constraints (#h filtering).
fixes:- #190

Summary: Fixes redundant sync teardown and re-initialization when navigating between rooms. Changes: - Removed room-based keying from syncSpaces - Sync now initializes once per space (URL-based) Impact: - Prevents unnecessary CLOSE/REQ cycles - Reduces network churn and CPU overhead Notes: Duplicate listeners inside syncSpace were not modified, as they appear intentional due to relay constraints (#h filtering). fixes:- #190
rajanarahul93 added 1 commit 2026-04-11 21:08:03 +00:00
fix: prevent redundant sync re-initialization on room navigation fefe1236a8
rajanarahul93 force-pushed fix/sync-space-reinit from edad66d7b0 to fefe1236a8 2026-04-11 21:08:03 +00:00 Compare
rajanarahul93 closed this pull request 2026-04-11 21:14:46 +00:00
rajanarahul93 commented 2026-04-11 21:14:56 +00:00
Author
First-time contributor
Copy Link
Copy Source

Closing this since the fix is already present in upstream (commit 9f386f69).

After syncing with the latest dev branch, the redundant re-initialization logic has already been removed and sync is now correctly URL-based.

No additional changes needed from this PR.

Closing this since the fix is already present in upstream (commit 9f386f69). After syncing with the latest dev branch, the redundant re-initialization logic has already been removed and sync is now correctly URL-based. No additional changes needed from this PR.
👍 1

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
design
For issues related to design work. Development should be done in another issue and refer back to this one.
 dev
Issues related to development work
 easy
Issues that can be executed on by new contributors
 idea
For issues that aren't yet actionable
 priority
For issues related to high priority features and bugs
 usability
Issues that have to be validated with real live human beings.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod) mplorentz (Matt Lorentz) sakshamjain (Saksham Jain) sondreb triesap userAdityaa (Aditya Chaudhary)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#193
Delete Branch "rajanarahul93/flotilla:fix/sync-space-reinit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?