Room Delete partial failure #194
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When you delete a room, it succeeds on the relay, but doesn't remove the room from the navigation, even after a refresh.
Hi @hodlbod. Can you assign me this issue for fixing this failure?
Hi @hodlbod. I've fixed the room delete failure and raised the PR for this. Kindly review the PR :)
Hi @hodlbod, I’m really sorry, it seems the PR got merged from my side unintentionally.
I was trying to squash my commits from my fork, but it looks like that action ended up merging the PR into the
devbranch of the upstream. That wasn’t my intention.Could you please let me know if I had write access, or how this might have happened? I’m happy to revert the changes or follow the correct process to fix this.
Apologies again for the confusion.
Oh, I see, no worries. I've force pushed on dev, so all good now. I left a comment on the PR, but I don't think that was the correct solution, I think it's probably more due to sync flakiness, which is going to be challenging to diagnose.
For more context, here's what I'm seeing. The room gets deleted on the relay, but the meta event gets retained while the room delete event doesn't seem to be.
@hodlbod is this issue open to be worked on?