Supported nips overflow #206
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
hey @hodlbod , would love to work on this issue!
@hodlbod, I think you uploaded a wrong image for this issue.
Oops, you're right, uploaded the correct one.
Is this fine? Or should I implement something like this
Supported NIPs: 1, 11, 42, 70, 86, 43, 40, BUD-00...When clicked, it will show all supported NIPS
Supported NIPs: 1, 11, 42, 70, 86, 43, 40, BUD-00, BUD-01, BUD-02, BUD-11, 29, 9, 77just like in ss I attached
That looks great, I think completeness is worth having
Just want to ask, to do changes, should I directly do changes in SpaceRelayStatus.svelte, or make a function and then proceed with the solution?
{#if Array.isArray(supported_nips)} {@const MAX=7} {@const nips=expanded?supported_nips:supported_nips.slice(0,MAX)} {@const hasMore=supported_nips.length>MAX} <button class="badge badge-neutral text-wrap h-auto cursor-pointer text-left" onclick={()=>expanded= !expanded}> <span class="ellipsize">Supported NIPs: {nips.join(", ")}{hasMore && !expanded ? "..." : ""}</span> </button> {/if}changed
<p>to<button>since I was getting warning when adding click handlers to non-interactive elements.Go ahead and open a PR and I'll review it there. I don't think we should do the slicing, what I meant was showing them all wrapped is fine.
sure!