Supported nips overflow #206

Closed
opened 2026-04-15 15:46:51 +00:00 by hodlbod · 8 comments
Owner
No description provided.
hodlbod added this to the Current milestone 2026-04-15 15:46:51 +00:00
hodlbod added the dev label 2026-04-15 15:46:51 +00:00
Contributor

hey @hodlbod , would love to work on this issue!

hey @hodlbod , would love to work on this issue!
Collaborator

@hodlbod, I think you uploaded a wrong image for this issue.

@hodlbod, I think you uploaded a wrong image for this issue.
Author
Owner

Oops, you're right, uploaded the correct one.

Oops, you're right, uploaded the correct one.
DeveshSingh was assigned by hodlbod 2026-04-15 21:25:05 +00:00
Contributor

Is this fine? Or should I implement something like this
Supported NIPs: 1, 11, 42, 70, 86, 43, 40, BUD-00...
When clicked, it will show all supported NIPS
Supported NIPs: 1, 11, 42, 70, 86, 43, 40, BUD-00, BUD-01, BUD-02, BUD-11, 29, 9, 77
just like in ss I attached

Is this fine? Or should I implement something like this `Supported NIPs: 1, 11, 42, 70, 86, 43, 40, BUD-00...` When clicked, it will show all supported NIPS `Supported NIPs: 1, 11, 42, 70, 86, 43, 40, BUD-00, BUD-01, BUD-02, BUD-11, 29, 9, 77` just like in ss I attached
Author
Owner

That looks great, I think completeness is worth having

That looks great, I think completeness is worth having
Contributor

That looks great, I think completeness is worth having

Just want to ask, to do changes, should I directly do changes in SpaceRelayStatus.svelte, or make a function and then proceed with the solution?

{#if Array.isArray(supported_nips)} {@const MAX=7} {@const nips=expanded?supported_nips:supported_nips.slice(0,MAX)} {@const hasMore=supported_nips.length>MAX} <button class="badge badge-neutral text-wrap h-auto cursor-pointer text-left" onclick={()=>expanded= !expanded}> <span class="ellipsize">Supported NIPs: {nips.join(", ")}{hasMore && !expanded ? "..." : ""}</span> </button> {/if}

changed <p> to <button> since I was getting warning when adding click handlers to non-interactive elements.

> That looks great, I think completeness is worth having Just want to ask, to do changes, should I directly do changes in SpaceRelayStatus.svelte, or make a function and then proceed with the solution? `{#if Array.isArray(supported_nips)} {@const MAX=7} {@const nips=expanded?supported_nips:supported_nips.slice(0,MAX)} {@const hasMore=supported_nips.length>MAX} <button class="badge badge-neutral text-wrap h-auto cursor-pointer text-left" onclick={()=>expanded= !expanded}> <span class="ellipsize">Supported NIPs: {nips.join(", ")}{hasMore && !expanded ? "..." : ""}</span> </button> {/if}` changed `<p>` to `<button>` since I was getting warning when adding click handlers to non-interactive elements.
Author
Owner

Go ahead and open a PR and I'll review it there. I don't think we should do the slicing, what I meant was showing them all wrapped is fine.

Go ahead and open a PR and I'll review it there. I don't think we should do the slicing, what I meant was showing them all wrapped is fine.
Contributor

Go ahead and open a PR and I'll review it there. I don't think we should do the slicing, what I meant was showing them all wrapped is fine.

sure!

> Go ahead and open a PR and I'll review it there. I don't think we should do the slicing, what I meant was showing them all wrapped is fine. sure!
Sign in to join this conversation.
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#206