coracle/flotilla
1
6
Fork 23
Code Issues 42 Pull Requests 2 Actions Packages Projects 5 Releases Wiki Activity

Fix deriveEventsByIdForUrl relay scoping to prevent cross-space event leakage #214

New Issue
Closed
opened 2026-04-16 20:15:15 +00:00 by userAdityaa · 3 comments
userAdityaa commented 2026-04-16 20:15:15 +00:00
Collaborator
Copy Link
Copy Source

Description

deriveEventsByIdForUrl currently reacts to tracker add/remove updates for any relay URL, not strictly the store target URL. This causes per-relay stores to include events from other relays and remove events incorrectly when unrelated relay mappings change.

Impact:

  • Inflates per-space store size
  • Causes extra update churn
  • Increases GC pressure in multi-space usage

Expected

  • storeA only contains events tracked on wss://a.
  • storeB only contains events tracked on wss://b.
  • Removing mapping from wss://b should not affect storeA unless event is no longer tracked on wss://a.

Related to: Improve Performace (#182)

### Description `deriveEventsByIdForUrl` currently reacts to tracker add/remove updates for any relay URL, not strictly the store target URL. This causes per-relay stores to include events from other relays and remove events incorrectly when unrelated relay mappings change. ### Impact: * Inflates per-space store size * Causes extra update churn * Increases GC pressure in multi-space usage ### Expected * storeA only contains events tracked on wss://a. * storeB only contains events tracked on wss://b. * Removing mapping from wss://b should not affect storeA unless event is no longer tracked on wss://a. Related to: [Improve Performace (#182)](https://gitea.coracle.social/coracle/flotilla/issues/182)
userAdityaa commented 2026-04-16 20:15:32 +00:00
Author
Collaborator
Copy Link
Copy Source

Hey @hodlbod, what are your thoughts on this?

I haven’t self-assigned it, if this is something that should be worked on now, I’d be happy to take it on. Thanks.

Hey @hodlbod, what are your thoughts on this? I haven’t self-assigned it, if this is something that should be worked on now, I’d be happy to take it on. Thanks.
userAdityaa added the dev label 2026-04-16 20:15:40 +00:00
hodlbod commented 2026-04-16 21:41:36 +00:00
Owner
Copy Link
Copy Source

Thank you, great observation. I put together a quick fix, let me know if you think this solves it: https://github.com/coracle-social/welshman/commit/2020276bf60a110aee26850a3d5d7110353c259e

Thank you, great observation. I put together a quick fix, let me know if you think this solves it: https://github.com/coracle-social/welshman/commit/2020276bf60a110aee26850a3d5d7110353c259e
🚀 1
userAdityaa commented 2026-04-17 08:23:16 +00:00
Author
Collaborator
Copy Link
Copy Source

Thank you for the quick fix, I went through the changes and verified the behaviour.
This resolves the issue from my side, closing this.

Thank you for the quick fix, I went through the changes and verified the behaviour. This resolves the issue from my side, closing this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
design
For issues related to design work. Development should be done in another issue and refer back to this one.
 dev
Issues related to development work
 easy
Issues that can be executed on by new contributors
 idea
For issues that aren't yet actionable
 priority
For issues related to high priority features and bugs
 usability
Issues that have to be validated with real live human beings.
No Label dev
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod) mplorentz (Matt Lorentz) sakshamjain (Saksham Jain) sondreb triesap userAdityaa (Aditya Chaudhary)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#214
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?