coracle/flotilla
1
6
Fork 23
Code Issues 42 Pull Requests 2 Actions Packages Projects 5 Releases Wiki Activity

chore: carify Pomade login errors with actionable invalid vs network messaging #233

Merged
hodlbod merged 1 commits from userAdityaa/flotilla:pomade-errors into dev 2026-04-17 23:00:03 +00:00
Conversation 0 Commits 1 Files Changed 6
+66 -9
userAdityaa commented 2026-04-17 22:01:49 +00:00
Collaborator
Copy Link
Copy Source

Summary

This PR fixes issue #226 by replacing ambiguous Pomade login failure messaging with specific user-actionable outcomes while preserving security constraints around account enumeration.

Each updated component now:

  • Has a try/catch block to detect network errors vs. authentication errors
  • Uses the error helper to display context-appropriate messages
  • Logs errors to console for debugging

Two Cases

Screenshot 2026-04-18 at 3.45.18 AM.png Screenshot 2026-04-18 at 3.45.41 AM.png
### Summary This PR fixes issue #226 by replacing ambiguous Pomade login failure messaging with specific user-actionable outcomes while preserving security constraints around account enumeration. ### Each updated component now: * Has a try/catch block to detect network errors vs. authentication errors * Uses the error helper to display context-appropriate messages * Logs errors to console for debugging ### Two Cases <img width="1440" alt="Screenshot 2026-04-18 at 3.45.18 AM.png" src="attachments/db3ee147-4bed-4710-b7c8-63d69779e069"> <img width="1439" alt="Screenshot 2026-04-18 at 3.45.41 AM.png" src="attachments/e8bb5183-b7c7-413b-8886-24c1ec1d75d8">
Screenshot 2026-04-18 at 3.45.18 AM.png
188 KiB
Screenshot 2026-04-18 at 3.45.41 AM.png
191 KiB
userAdityaa marked the pull request as work in progress 2026-04-17 22:14:57 +00:00
userAdityaa marked the pull request as ready for review 2026-04-17 22:29:44 +00:00
hodlbod added 1 commit 2026-04-17 22:59:59 +00:00
chore: carify Pomade login errors with actionable invalid vs network messaging 2c3c997f39
hodlbod force-pushed pomade-errors from d0b8b581cd to 2c3c997f39 2026-04-17 22:59:59 +00:00 Compare
hodlbod merged commit 24aa62a503 into dev 2026-04-17 23:00:03 +00:00
hodlbod deleted branch pomade-errors 2026-04-17 23:00:04 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
design
For issues related to design work. Development should be done in another issue and refer back to this one.
 dev
Issues related to development work
 easy
Issues that can be executed on by new contributors
 idea
For issues that aren't yet actionable
 priority
For issues related to high priority features and bugs
 usability
Issues that have to be validated with real live human beings.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod) mplorentz (Matt Lorentz) sakshamjain (Saksham Jain) sondreb triesap userAdityaa (Aditya Chaudhary)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#233
Delete Branch "userAdityaa/flotilla:pomade-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?