coracle/flotilla
1
3
Fork 9
Code Issues 32 Pull Requests 1 Actions Packages Projects 5 Releases Wiki Activity

feature/23-voice-room/poc #93

Merged
hodlbod merged 68 commits from feature/23-voice-room/poc into dev 2026-03-16 20:38:06 +00:00
Conversation 28 Commits 68 Files Changed 28
+17 -4
1 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 25228f785d - Show all commits
src/app/voice.ts
+17 -4
View File
4
 @@ -168,13 +168,15 @@ export const joinVoiceRoom = async (
throw e
}
let muted = false
try {
await room.localParticipant.setMicrophoneEnabled(true)
} catch (e) {
muted = true
pushToast({theme: "error", message: "Could not access microphone"})
}
currentVoiceSession.set({url, h, room, muted: false})
currentVoiceSession.set({url, h, room, muted})
startPresenceHeartbeat(url, h)
}
@@ -190,11 +192,22 @@ export const leaveVoiceRoom = async () => {
currentVoiceSession.set(undefined)
}
export const toggleMute = () => {
export const toggleMute = async () => {
const session = get(currentVoiceSession)
if (!session) return
hodlbod marked this conversation as resolved Outdated
hodlbod commented 2026-03-03 23:45:26 +00:00
Outdated
Review
Copy Link
Copy Source

This will never happen because there are no awaits between this and the previous check.

The if (signal) is redundant too, we should just require the caller to provide a signal.

This will never happen because there are no awaits between this and the previous check. The if (signal) is redundant too, we should just require the caller to provide a signal.
👍 1
const muted = !session.muted
session.room.localParticipant.setMicrophoneEnabled(!muted)
currentVoiceSession.set({...session, muted})
if (muted) {
// Disable and re-enable microphone to trigger permission prompt
session.room.localParticipant.setMicrophoneEnabled(false)
currentVoiceSession.set({...session, muted})
return
}
try {
await session.room.localParticipant.setMicrophoneEnabled(true)
currentVoiceSession.set({...session, muted})
} catch (e) {
pushToast({theme: "error", message: "Could not access microphone"})
}
}