coracle/flotilla
1
3
Fork 9
Code Issues 31 Pull Requests 1 Actions Packages Projects 5 Releases Wiki Activity

feature/23-voice-room/poc #93

Merged
hodlbod merged 68 commits from feature/23-voice-room/poc into dev 2026-03-16 20:38:06 +00:00
Conversation 28 Commits 68 Files Changed 28
+5 -4
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 697804c621 - Show all commits
src/app/components/RoomImage.svelte
+3 -2
View File
@@ -8,9 +8,10 @@
h: string
url: string
size?: number
fallbackIcon?: string
}
const {url, h, size = 5}: Props = $props()
const {url, h, size = 5, fallbackIcon = Hashtag}: Props = $props()
const room = deriveRoom(url, h)
</script>
@@ -18,5 +19,5 @@
{#if $room.picture}
<ImageIcon src={$room.picture} {size} alt="" class="rounded-lg" />
{:else}
<Icon icon={Hashtag} {size} />
<Icon icon={fallbackIcon} {size} />
{/if}
hodlbod marked this conversation as resolved Outdated
hodlbod commented 2026-03-13 19:58:21 +00:00
Outdated
Review
Copy Link
Copy Source

Now that we're showing the widget in the room, I think we can probably get rid of this change, what do you think?

Now that we're showing the widget in the room, I think we can probably get rid of this change, what do you think?
mplorentz commented 2026-03-16 13:29:01 +00:00
Outdated
Review
Copy Link
Copy Source

I'm confused - did you want to show the VoiceWidget only on the room page? Right now I have it showing in the SpaceMenu on desktop and both in SpaceMenu and on the room page on mobile. It seems like a better use of space on desktop to have it down in the corner than to stretch it across the whole width of the chat room.

I'm confused - did you want to show the VoiceWidget *only* on the room page? Right now I have it showing in the SpaceMenu on desktop and both in SpaceMenu and on the room page on mobile. It seems like a better use of space on desktop to have it down in the corner than to stretch it across the whole width of the chat room.
mplorentz commented 2026-03-16 13:35:49 +00:00
Outdated
Review
Copy Link
Copy Source

I guess that's orthogonal to the question of whether we want a different icon for voice rooms once you have joined them. I think it's a nice affordance if you are looking a the sidebar to be able to tell which room you are in without having to read the room name out of the voice widget.

I guess that's orthogonal to the question of whether we want a different icon for voice rooms once you have joined them. I think it's a nice affordance if you are looking a the sidebar to be able to tell which room you are in without having to read the room name out of the voice widget.
hodlbod commented 2026-03-16 20:30:48 +00:00
Outdated
Review
Copy Link
Copy Source

Yeah, I just mean we should just show the room's actual icon at the top of the page regardless of whether the room is active (the widget at the bottom will be indication enough)

Yeah, I just mean we should just show the room's actual icon at the top of the page regardless of whether the room is active (the widget at the bottom will be indication enough)
src/app/components/VoiceRoomItem.svelte
+2 -2
View File
@@ -3,9 +3,9 @@
import {loadProfile, displayProfileByPubkey} from "@welshman/app"
import Volume from "@assets/icons/volume.svg?dataurl"
import VolumeLoud from "@assets/icons/volume-loud.svg?dataurl"
import Icon from "@lib/components/Icon.svelte"
import SecondaryNavItem from "@lib/components/SecondaryNavItem.svelte"
import ProfileCircle from "@app/components/ProfileCircle.svelte"
import RoomImage from "@app/components/RoomImage.svelte"
import RoomName from "@app/components/RoomName.svelte"
import {pushToast} from "@app/util/toast"
import {
8
 @@ -62,7 +62,7 @@
{#if joinAbortController}
<span class="loading loading-spinner loading-sm"></span>
{:else}
<Icon icon={isActive ? VolumeLoud : Volume} size={4} class="opacity-70" />
<RoomImage {url} {h} size={4} fallbackIcon={isActive ? VolumeLoud : Volume} />
{/if}
<RoomName {url} {h} />
</div>
2