coracle/flotilla
1
3
Fork 9
Code Issues 32 Pull Requests 1 Actions Packages Projects 5 Releases Wiki Activity

feature/23-voice-room/poc #93

Merged
hodlbod merged 68 commits from feature/23-voice-room/poc into dev 2026-03-16 20:38:06 +00:00
Conversation 28 Commits 68 Files Changed 28
+4 -7
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 697c116956 - Show all commits
src/app/components/VoiceRoomItem.svelte
+4 -7
View File
@@ -25,27 +25,24 @@
const participants = deriveVoiceParticipants(url, h)
const isActive = $derived($currentVoiceSession?.url === url && $currentVoiceSession?.h === h)
let isJoining = $state(false)
let joinAbortController: AbortController | undefined
let joinAbortController = $state<AbortController | undefined>(undefined)
const handleClick = async () => {
if (isActive) {
await leaveVoiceRoom()
return
}
if (isJoining) {
joinAbortController?.abort()
if (joinAbortController) {
hodlbod marked this conversation as resolved Outdated
hodlbod commented 2026-03-05 22:40:15 +00:00
Outdated
Review
Copy Link
Copy Source

Instead of this, we should just not render voice rooms on mobile

Instead of this, we should just not render voice rooms on mobile
👍 1
mplorentz commented 2026-03-06 16:02:20 +00:00
Outdated
Review
Copy Link
Copy Source

I tried that, but realized that you could then join a call on desktop web, resize your browser to be small and then lose the UI to leave the call. As I type it out I realize that's too edgy of a case 😂 I will just hide it.

I tried that, but realized that you could then join a call on desktop web, resize your browser to be small and then lose the UI to leave the call. As I type it out I realize that's too edgy of a case 😂 I will just hide it.
joinAbortController.abort()
return
}
joinAbortController = new AbortController()
isJoining = true
try {
await joinVoiceRoom(url, h, joinAbortController.signal)
} catch (e) {
console.error("Failed to join voice room", e)
pushToast({theme: "error", message: "Failed to join voice room"})
} finally {
hodlbod marked this conversation as resolved Outdated
hodlbod commented 2026-03-05 22:41:57 +00:00
Outdated
Review
Copy Link
Copy Source

[nit] in situations like this, I like to overload the controller as the isJoining boolean and just check whether joinAbortController is undefined. One fewer variable to keep track of

[nit] in situations like this, I like to overload the controller as the isJoining boolean and just check whether joinAbortController is undefined. One fewer variable to keep track of
👍 1
isJoining = false
joinAbortController = undefined
}
}
5
 @@ -62,7 +59,7 @@
class={cx("!items-start", isActive && "!bg-base-100 !text-base-content")}>
<div class="flex w-full min-w-0 flex-col gap-2">
<div class="flex gap-2 items-center">
{#if isJoining}
{#if joinAbortController}
<span class="loading loading-spinner loading-sm"></span>
{:else}
<Icon icon={isActive ? VolumeLoud : Volume} size={4} class="opacity-70" />
2