coracle/flotilla
1
3
Fork 9
Code Issues 32 Pull Requests 1 Actions Packages Projects 5 Releases Wiki Activity

feature/23-voice-room/poc #93

Merged
hodlbod merged 68 commits from feature/23-voice-room/poc into dev 2026-03-16 20:38:06 +00:00
Conversation 28 Commits 68 Files Changed 28
+5 -2
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c518926c2b - Show all commits
src/app/components/VoiceWidget.svelte
+5 -2
View File
@@ -1,4 +1,5 @@
<script lang="ts">
import {ifLet} from "@welshman/lib"
import {displayRelayUrl} from "@welshman/util"
import Microphone from "@assets/icons/microphone.svg?dataurl"
import MicrophoneOff from "@assets/icons/microphone-off.svg?dataurl"
@@ -8,6 +9,7 @@
import Button from "@lib/components/Button.svelte"
import {displayRoom} from "@app/core/state"
import RoomDetail from "@app/components/RoomDetail.svelte"
import type {VoiceSession} from "@app/voice"
import {currentVoiceSession, leaveVoiceRoom, toggleMute} from "@app/voice"
import {pushModal} from "@app/util/modal"
@@ -17,8 +19,9 @@
const spaceName = $derived($currentVoiceSession ? displayRelayUrl($currentVoiceSession.url) : "")
const showRoomDetail = () => {
hodlbod marked this conversation as resolved Outdated
hodlbod commented 2026-03-03 23:27:06 +00:00
Outdated
Review
Copy Link
Copy Source

Don't do indirection like this, just call the actual function

Don't do indirection like this, just call the actual function
👍 1
hodlbod commented 2026-03-05 22:47:21 +00:00
Outdated
Review
Copy Link
Copy Source

A stupid way to do this that I like would be ifLet($currentVoiceSession, ({url, h}) => pushModal(RoomDetail, {url, h})) but you don't have to do that

A stupid way to do this that I like would be `ifLet($currentVoiceSession, ({url, h}) => pushModal(RoomDetail, {url, h}))` but you don't have to do that
mplorentz commented 2026-03-09 14:45:35 +00:00
Outdated
Review
Copy Link
Copy Source

It is harder to read at first glance but ifLet brings warm feelings from better programming languages so it's done.

It is harder to read at first glance but `ifLet` brings warm feelings from better programming languages so it's done.
const session = $currentVoiceSession
if (session) pushModal(RoomDetail, {url: session.url, h: session.h})
ifLet($currentVoiceSession, (session: VoiceSession) =>
pushModal(RoomDetail, {url: session.url, h: session.h}),
)
hodlbod marked this conversation as resolved Outdated
hodlbod commented 2026-03-03 23:28:31 +00:00
Outdated
Review
Copy Link
Copy Source

$currentVoiceSession is better than get

$currentVoiceSession is better than `get`
}
</script>
3