coracle/welshman
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify comment tags

Browse Source
This commit is contained in:
Jon Staab
2025-03-03 12:53:52 -08:00
parent 100f80d4b8
commit 3e289e9eac
2 changed files with 22 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/app/__tests__/tags.test.ts
+18 -16
View File
@@ -262,10 +262,14 @@ describe("tags", () => {
}
const result = tagEventForComment(eventWithMultipleRoots)
// First root should be uppercase
expect(result.some(tag => tag[0] === "E" && tag[1] === id1)).toBe(true)
// Subsequent roots should be lowercase
expect(result.some(tag => tag[0] === "e" && tag[1] === id2)).toBe(true)
expect(result).toEqual([
["K", String(NOTE)],
["P", pubkey, "pubkey-relay-url"],
["E", id, "event-relay-url", pubkey],
["k", String(NOTE)],
["p", pubkey, "pubkey-relay-url"],
["e", id, "event-relay-url", pubkey],
])
})
it("should handle events with mixed tag types", () => {
@@ -282,18 +286,16 @@ describe("tags", () => {
}
const result = tagEventForComment(eventWithMixedTags)
// Should propagate root tags (e, p, i, a) to uppercase
expect(result.some(tag => tag[0] === "E" && tag[1] === id)).toBe(true)
expect(result.some(tag => tag[0] === "P" && tag[1] === pubkey1)).toBe(true)
expect(result.some(tag => tag[0] === "I" && tag[1] === id1)).toBe(true)
expect(result.some(tag => tag[0] === "A" && tag[1] === "some-address")).toBe(true)
// Should include parent variants in lowercase
expect(result.some(tag => tag[0] === "e" && tag[1] === id)).toBe(true)
expect(result.some(tag => tag[0] === "p" && tag[1] === pubkey1)).toBe(true)
// Should not include non-relevant tags
expect(result.some(tag => tag[0] === "custom")).toBe(false)
expect(result).toEqual([
["K", String(MUTES)],
["P", pubkey, "pubkey-relay-url"],
["E", id, "event-relay-url", pubkey],
["A", getAddress(eventWithMixedTags), "event-relay-url", pubkey],
["k", String(MUTES)],
["p", pubkey, "pubkey-relay-url"],
["e", id, "event-relay-url", pubkey],
["a", getAddress(eventWithMixedTags), "event-relay-url", pubkey],
])
})
it("should add event metadata tags when no root tags exist", () => {