From 462a2afe45cdadd6584e9df47cc97238aab1712c Mon Sep 17 00:00:00 2001
From: Jon Staab <shtaab@gmail.com>
Date: Thu, 2 Jan 2025 10:41:26 -0800
Subject: [PATCH] Use template strings instead of join for speed

---
 packages/net/src/Executor.ts | 2 +-
 packages/signer/src/util.ts  | 2 +-
 packages/util/src/Address.ts | 2 +-
 packages/util/src/Events.ts  | 2 +-
 packages/util/src/Filters.ts | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/net/src/Executor.ts b/packages/net/src/Executor.ts
index f93b27b..1732e08 100644
--- a/packages/net/src/Executor.ts
+++ b/packages/net/src/Executor.ts
@@ -27,7 +27,7 @@ type SubscribeOpts = {onEvent?: EventCallback; onEose?: EoseCallback}
 type PublishOpts = {verb?: string; onOk?: OkCallback; onError?: ErrorCallback}
 type DiffOpts = {onError?: ErrorCallback; onMessage?: DiffMessageCallback; onClose?: CloseCallback}
 
-const createSubId = (prefix: string) => [prefix, Math.random().toString().slice(2, 10)].join("-")
+const createSubId = (prefix: string) => `${prefix}-${Math.random().toString().slice(2, 10)}`
 
 export class Executor {
   constructor(readonly target: Target) {}
diff --git a/packages/signer/src/util.ts b/packages/signer/src/util.ts
index 508c6d8..7dd9fb5 100644
--- a/packages/signer/src/util.ts
+++ b/packages/signer/src/util.ts
@@ -32,7 +32,7 @@ export const nip04 = {
 export const nip44 = {
   getSharedSecret: cached({
     maxSize: 10000,
-    getKey: ([secret, pubkey]) => [secret, pubkey].join(":"),
+    getKey: ([secret, pubkey]) => `${secret}:${pubkey}`,
     getValue: ([secret, pubkey]: string[]) =>
       nt44.v2.utils.getConversationKey(hexToBytes(secret), pubkey),
   }),
diff --git a/packages/util/src/Address.ts b/packages/util/src/Address.ts
index b96c218..9904e4c 100644
--- a/packages/util/src/Address.ts
+++ b/packages/util/src/Address.ts
@@ -49,7 +49,7 @@ export class Address {
     return new Address(event.kind, event.pubkey, identifier, relays)
   }
 
-  toString = () => [this.kind, this.pubkey, this.identifier].join(":")
+  toString = () => `${this.kind}:${this.pubkey}:${this.identifier}`
 
   toNaddr = () => naddrEncode(this)
 }
diff --git a/packages/util/src/Events.ts b/packages/util/src/Events.ts
index 83ef72d..a9a77b4 100644
--- a/packages/util/src/Events.ts
+++ b/packages/util/src/Events.ts
@@ -101,7 +101,7 @@ const _hasValidSignature = cached<string, boolean, [SignedEvent]>({
   maxSize: 10000,
   getKey: ([e]: [SignedEvent]) => {
     try {
-      return [getEventHash(e), e.sig].join(":")
+      return `${getEventHash(e)}:${e.sig}`
     } catch (err) {
       return "invalid"
     }
diff --git a/packages/util/src/Filters.ts b/packages/util/src/Filters.ts
index 803a81f..fde6ca0 100644
--- a/packages/util/src/Filters.ts
+++ b/packages/util/src/Filters.ts
@@ -71,7 +71,7 @@ export const getFilterId = (filter: Filter) => {
     const v = filter[k as keyof Filter]
     const s = Array.isArray(v) ? v.join(",") : v
 
-    parts.push([k, s].join(":"))
+    parts.push(`${k}:${s}`)
   }
 
   return hash(parts.join("|"))