fix: Address review findings (CRITICAL/HIGH)
CRITICAL fixes: - Stop passing mint URLs as relay URLs in initNDK (protocol mismatch) - Add unit tests for buildTransactionHistory (dedup, fallback, sort) HIGH fixes: - Restore .claude entry in .gitignore - Add warning logging for skipped malformed proof tags in nutzap parsing - Add error handling + 30s timeout to NDK initialization - Add unit tests for formatCSV and escapeField - Export escapeField for testability Also: add test script to package.json, include test/ in tsconfig Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
+2
-2
@@ -35,8 +35,8 @@ async function main() {
|
||||
? args[mintsIdx + 1].split(",").filter(Boolean)
|
||||
: [];
|
||||
|
||||
// Initialize NDK
|
||||
const { ndk, signer, user } = await initNDK(secretKey, extraMints);
|
||||
// Initialize NDK (don't pass mints as relays — they use different protocols)
|
||||
const { ndk, signer, user } = await initNDK(secretKey);
|
||||
|
||||
// Fetch wallet data first (need mints for context)
|
||||
const walletData = await fetchWalletData(ndk, user, signer);
|
||||
|
||||
Reference in New Issue
Block a user