Just leave getTagValues, getRoomDeleteId is unnecessary if you understand the data model
It looks like this is the only substantial change, is that all?
Leave badge and sound alone I think, push is enough.
Looks pretty good, just a couple small things.
Let's keep sound off too, that's an optional add on. Web users will still be notified about push
I see, the roomMetaEventsByIdByUrl isn't populated until the event is accepted by the relay? This should be something taken care of by welshman's thunk — it populates both repository and tracker…
This can be $dmNotificationsPrompted if it's in a svelte component
Unless we need to return an unsubscribe function from onMount, we can just make the closure async and avoid the define/call function pattern.
$notificationSettings. But don't actually check this, we want to turn these on here; this guard will make this function a no-op.
All of this should be handled by the push adapters. This should be as simple as calling Push.request() below.
notificationSettings.update would be more idiomatic here
This can't default to true, because push is only true if we've successfully requested permissions.
this is unnecessary, deletes are already in roomMetaEventsByUrl right?