From 404dc94c345e64b204d24ceb91ca3e6068c7a8d8 Mon Sep 17 00:00:00 2001
From: Jon Staab <shtaab@gmail.com>
Date: Mon, 9 Dec 2024 17:04:39 -0800
Subject: [PATCH] Display rooms using nip29 meta

---
 src/app/components/ChannelName.svelte         |  12 ++
 src/app/components/MenuSpace.svelte           |  34 ++++-
 src/app/components/MenuSpaceRoomItem.svelte   |   4 +-
 src/app/components/ThreadShare.svelte         |  13 +-
 src/app/state.ts                              | 141 ++++++++++++------
 src/routes/spaces/[relay]/+page.svelte        |  19 ++-
 src/routes/spaces/[relay]/[room]/+page.svelte |   6 +-
 7 files changed, 157 insertions(+), 72 deletions(-)
 create mode 100644 src/app/components/ChannelName.svelte

diff --git a/src/app/components/ChannelName.svelte b/src/app/components/ChannelName.svelte
new file mode 100644
index 00000000..6238c462
--- /dev/null
+++ b/src/app/components/ChannelName.svelte
@@ -0,0 +1,12 @@
+<script lang="ts">
+  import {GENERAL, channelsById, makeChannelId} from "@app/state"
+
+  export let url
+  export let room
+</script>
+
+{#if room === GENERAL}
+  general
+{:else}
+  {$channelsById.get(makeChannelId(url, room))?.name || room}
+{/if}
diff --git a/src/app/components/MenuSpace.svelte b/src/app/components/MenuSpace.svelte
index 3ab367f5..81ae4775 100644
--- a/src/app/components/MenuSpace.svelte
+++ b/src/app/components/MenuSpace.svelte
@@ -1,6 +1,8 @@
 <script lang="ts">
   import {onMount} from "svelte"
-  import {displayRelayUrl} from "@welshman/util"
+  import {sortBy} from "@welshman/lib"
+  import {displayRelayUrl, GROUP_META} from "@welshman/util"
+  import {load} from "@welshman/app"
   import {fly} from "@lib/transition"
   import Icon from "@lib/components/Icon.svelte"
   import Button from "@lib/components/Button.svelte"
@@ -13,6 +15,7 @@
   import SpaceJoin from "@app/components/SpaceJoin.svelte"
   import ProfileList from "@app/components/ProfileList.svelte"
   import RoomCreate from "@app/components/RoomCreate.svelte"
+  import ChannelName from "@app/components/ChannelName.svelte"
   import MenuSpaceRoomItem from "@app/components/MenuSpaceRoomItem.svelte"
   import {
     getMembershipRoomsByUrl,
@@ -20,8 +23,9 @@
     hasMembershipUrl,
     userMembership,
     memberships,
-    roomsByUrl,
+    channelsByUrl,
     GENERAL,
+    displayChannel,
   } from "@app/state"
   import {deriveNotification, THREAD_FILTERS} from "@app/notifications"
   import {pushModal} from "@app/modal"
@@ -58,13 +62,28 @@
   let showMenu = false
   let replaceState = false
   let element: Element
+  let userRooms: string[] = []
+  let otherRooms: string[] = []
 
-  $: rooms = getMembershipRoomsByUrl(url, $userMembership)
-  $: otherRooms = ($roomsByUrl.get(url) || []).filter(room => !rooms.concat(GENERAL).includes(room))
   $: members = $memberships.filter(l => hasMembershipUrl(l, url)).map(l => l.event.pubkey)
 
+  $: {
+    userRooms = [GENERAL, ...getMembershipRoomsByUrl(url, $userMembership)]
+    otherRooms = []
+
+    for (const channel of $channelsByUrl.get(url) || []) {
+      if (!userRooms.includes(channel.room)) {
+        otherRooms.push(channel.room)
+      }
+    }
+
+    userRooms = sortBy(room => displayChannel(url, room), userRooms)
+    otherRooms = sortBy(room => displayChannel(url, room), otherRooms)
+  }
+
   onMount(async () => {
     replaceState = Boolean(element.closest(".drawer"))
+    load({relays: [url], filters: [{kinds: [GROUP_META]}]})
   })
 </script>
 
@@ -118,14 +137,13 @@
       </SecondaryNavItem>
       <div class="h-2" />
       <SecondaryNavHeader>Your Rooms</SecondaryNavHeader>
-      <MenuSpaceRoomItem {url} room={GENERAL} />
-      {#each rooms as room, i (room)}
+      {#each userRooms as room, i (room)}
         <MenuSpaceRoomItem {url} {room} />
       {/each}
       {#if otherRooms.length > 0}
         <div class="h-2" />
         <SecondaryNavHeader>
-          {#if rooms.length > 0}
+          {#if userRooms.length > 0}
             Other Rooms
           {:else}
             Rooms
@@ -135,7 +153,7 @@
       {#each otherRooms as room, i (room)}
         <SecondaryNavItem href={makeSpacePath(url, room)}>
           <Icon icon="hashtag" />
-          {room}
+          <ChannelName {url} {room} />
         </SecondaryNavItem>
       {/each}
       <SecondaryNavItem on:click={addRoom}>
diff --git a/src/app/components/MenuSpaceRoomItem.svelte b/src/app/components/MenuSpaceRoomItem.svelte
index c2808c4a..570bfd6b 100644
--- a/src/app/components/MenuSpaceRoomItem.svelte
+++ b/src/app/components/MenuSpaceRoomItem.svelte
@@ -1,8 +1,8 @@
 <script lang="ts">
   import Icon from "@lib/components/Icon.svelte"
   import SecondaryNavItem from "@lib/components/SecondaryNavItem.svelte"
+  import ChannelName from "@app/components/ChannelName.svelte"
   import {makeSpacePath} from "@app/routes"
-  import {displayRoom} from "@app/state"
   import {deriveNotification, getRoomFilters} from "@app/notifications"
 
   export let url
@@ -14,5 +14,5 @@
 
 <SecondaryNavItem href={path} notification={$notification}>
   <Icon icon="hashtag" />
-  {displayRoom(room)}
+  <ChannelName {url} {room} />
 </SecondaryNavItem>
diff --git a/src/app/components/ThreadShare.svelte b/src/app/components/ThreadShare.svelte
index e64a61c6..5165a4ab 100644
--- a/src/app/components/ThreadShare.svelte
+++ b/src/app/components/ThreadShare.svelte
@@ -7,7 +7,8 @@
   import Button from "@lib/components/Button.svelte"
   import ModalHeader from "@lib/components/ModalHeader.svelte"
   import ModalFooter from "@lib/components/ModalFooter.svelte"
-  import {roomsByUrl} from "@app/state"
+  import ChannelName from "@app/components/ChannelName.svelte"
+  import {channelsByUrl} from "@app/state"
   import {makeRoomPath} from "@app/routes"
   import {setKey} from "@app/implicit"
 
@@ -37,14 +38,14 @@
     <div slot="info">Which room would you like to share this thread to?</div>
   </ModalHeader>
   <div class="grid grid-cols-3 gap-2">
-    {#each $roomsByUrl.get(url) || [] as room (room)}
+    {#each $channelsByUrl.get(url) || [] as channel (channel.room)}
       <button
         type="button"
         class="btn"
-        class:btn-neutral={selection !== room}
-        class:btn-primary={selection === room}
-        on:click={() => toggleRoom(room)}>
-        #{room}
+        class:btn-neutral={selection !== channel.room}
+        class:btn-primary={selection === channel.room}
+        on:click={() => toggleRoom(channel.room)}>
+        #<ChannelName {...channel} />
       </button>
     {/each}
   </div>
diff --git a/src/app/state.ts b/src/app/state.ts
index 53a060ff..47ef5617 100644
--- a/src/app/state.ts
+++ b/src/app/state.ts
@@ -15,6 +15,7 @@ import {
   nthEq,
   shuffle,
   parseJson,
+  fromPairs,
 } from "@welshman/lib"
 import {
   getIdFilters,
@@ -24,6 +25,7 @@ import {
   REACTION,
   ZAP_RESPONSE,
   DIRECT_MESSAGE,
+  GROUP_META,
   getGroupTags,
   getRelayTagValues,
   getPubkeyTagValues,
@@ -444,63 +446,108 @@ export const chatSearch = derived(chats, $chats =>
 
 export const messages = deriveEvents(repository, {filters: [{kinds: [MESSAGE]}]})
 
+// Group Meta
+
+export const groupMeta = deriveEvents(repository, {filters: [{kinds: [GROUP_META]}]})
+
 // Channels
 
+export type ChannelMeta = {
+  access: "public" | "private"
+  membership: "open" | "closed"
+  picture?: string
+  about?: string
+}
+
 export type Channel = {
   url: string
   room: string
   name: string
   events: TrustedEvent[]
+  meta?: ChannelMeta
 }
 
 export const makeChannelId = (url: string, room: string) => `${url}|${room}`
 
 export const splitChannelId = (id: string) => id.split("|")
 
-export const channelsById = derived(
-  [memberships, messages, trackerStore],
-  ([$memberships, $messages, $tracker]) => {
-    const eventsByChannelId = new Map<string, TrustedEvent[]>()
+export const channelsById = withGetter(
+  derived(
+    [groupMeta, memberships, messages, trackerStore],
+    ([$groupMeta, $memberships, $messages, $tracker]) => {
+      const eventsByChannelId = new Map<string, TrustedEvent[]>()
 
-    // Add known rooms by membership so we have a full listing even if there are no messages there
-    for (const membership of $memberships) {
-      for (const {url, room} of getMembershipRooms(membership)) {
-        eventsByChannelId.set(makeChannelId(url, room), [])
-      }
-    }
-
-    // Add known messages to rooms
-    for (const event of $messages) {
-      const [_, room] = event.tags.find(nthEq(0, ROOM)) || []
-
-      if (room) {
-        for (const url of $tracker.getRelays(event.id)) {
-          pushToMapKey(eventsByChannelId, makeChannelId(url, room), event)
-        }
-      }
-    }
-
-    const channelsById = new Map<string, Channel>()
-
-    for (const [id, unsorted] of eventsByChannelId.entries()) {
-      const [url, room] = splitChannelId(id)
-      const events = sortBy(e => -e.created_at, unsorted)
-
-      let name = room
-      for (const event of events) {
-        const tag = event.tags.find(t => t[0] === ROOM && t[2])
-
-        if (tag) {
-          name = tag[2]
-          break
+      // Add known rooms by membership so we have a full listing even if there are no messages there
+      for (const membership of $memberships) {
+        for (const {url, room} of getMembershipRooms(membership)) {
+          eventsByChannelId.set(makeChannelId(url, room), [])
         }
       }
 
-      channelsById.set(id, {url, room, name, events})
-    }
+      // Add known messages to rooms
+      for (const event of $messages) {
+        const [_, room] = event.tags.find(nthEq(0, ROOM)) || []
 
-    return channelsById
-  },
+        if (room) {
+          for (const url of $tracker.getRelays(event.id)) {
+            pushToMapKey(eventsByChannelId, makeChannelId(url, room), event)
+          }
+        }
+      }
+
+      const channelsById = new Map<string, Channel>()
+
+      for (const [id, unsorted] of eventsByChannelId.entries()) {
+        const [url, room] = splitChannelId(id)
+        const events = sortBy(e => -e.created_at, unsorted)
+
+        let name = room
+        for (const event of events) {
+          const tag = event.tags.find(t => t[0] === ROOM && t[2])
+
+          if (tag) {
+            name = tag[2]
+            break
+          }
+        }
+
+        channelsById.set(id, {url, room, name, events})
+      }
+
+      // Add meta using group meta events
+      for (const event of $groupMeta) {
+        const meta = fromPairs(event.tags)
+        const room = meta.d
+
+        if (room) {
+          for (const url of $tracker.getRelays(event.id)) {
+            const id = makeChannelId(url, room)
+            const channel: Channel = channelsById.get(id) || {
+              url,
+              room,
+              name: room,
+              events: [],
+            }
+
+            if (meta.name) {
+              channel.name = meta.name
+            }
+
+            channel.meta = {
+              access: meta.public ? "public" : "private",
+              membership: meta.open ? "open" : "closed",
+              picture: meta.picture,
+              about: meta.about,
+            }
+
+            channelsById.set(id, channel)
+          }
+        }
+      }
+
+      return channelsById
+    },
+  ),
 )
 
 export const deriveChannel = (url: string, room: string) =>
@@ -509,24 +556,22 @@ export const deriveChannel = (url: string, room: string) =>
 export const deriveChannelMessages = (url: string, room: string) =>
   derived(channelsById, $channelsById => $channelsById.get(makeChannelId(url, room))?.events || [])
 
-// Rooms
+export const channelsByUrl = derived(channelsById, $channelsById => {
+  const $channelsByUrl = new Map<string, Channel[]>()
 
-export const roomsByUrl = derived(channelsById, $channelsById => {
-  const $roomsByUrl = new Map<string, string[]>()
-
-  for (const {url, room} of $channelsById.values()) {
-    pushToMapKey($roomsByUrl, url, room)
+  for (const channel of $channelsById.values()) {
+    pushToMapKey($channelsByUrl, channel.url, channel)
   }
 
-  return $roomsByUrl
+  return $channelsByUrl
 })
 
-export const displayRoom = (room: string) => {
+export const displayChannel = (url: string, room: string) => {
   if (room === GENERAL) {
     return "general"
   }
 
-  return room
+  return channelsById.get().get(makeChannelId(url, room))?.name || room
 }
 
 // User stuff
diff --git a/src/routes/spaces/[relay]/+page.svelte b/src/routes/spaces/[relay]/+page.svelte
index 85e0016d..114fe60a 100644
--- a/src/routes/spaces/[relay]/+page.svelte
+++ b/src/routes/spaces/[relay]/+page.svelte
@@ -7,9 +7,10 @@
   import PageBar from "@lib/components/PageBar.svelte"
   import MenuSpaceButton from "@app/components/MenuSpaceButton.svelte"
   import ProfileFeed from "@app/components/ProfileFeed.svelte"
+  import ChannelName from "@app/components/ChannelName.svelte"
   import RelayName from "@app/components/RelayName.svelte"
   import RelayDescription from "@app/components/RelayDescription.svelte"
-  import {decodeRelay, roomsByUrl} from "@app/state"
+  import {decodeRelay, channelsByUrl} from "@app/state"
   import {makeChatPath, makeRoomPath, makeSpacePath} from "@app/routes"
 
   const url = decodeRelay($page.params.relay)
@@ -87,14 +88,20 @@
         </div>
       {/if}
     </div>
-    <div class="grid grid-cols-3 gap-2 md:hidden">
-      <Link href={makeSpacePath(url, "threads")} class="bg-alt btn btn-neutral border-none">
+    <div class="grid grid-cols-3 gap-2">
+      <Link
+        href={makeSpacePath(url, "threads")}
+        class="bg-alt btn btn-neutral justify-start border-none">
         <Icon icon="notes-minimalistic" /> Threads
       </Link>
-      {#each $roomsByUrl.get(url) || [] as room (room)}
-        <Link href={makeRoomPath(url, room)} class="bg-alt btn btn-neutral border-none">
+      {#each $channelsByUrl.get(url) || [] as channel (channel.room)}
+        <Link
+          href={makeRoomPath(url, channel.room)}
+          class="bg-alt btn btn-neutral flex-nowrap justify-start whitespace-nowrap border-none">
           <Icon icon="hashtag" />
-          {room}
+          <div class="min-w-0 overflow-hidden text-ellipsis">
+            <ChannelName {...channel} />
+          </div>
         </Link>
       {/each}
     </div>
diff --git a/src/routes/spaces/[relay]/[room]/+page.svelte b/src/routes/spaces/[relay]/[room]/+page.svelte
index 169371f9..44fce464 100644
--- a/src/routes/spaces/[relay]/[room]/+page.svelte
+++ b/src/routes/spaces/[relay]/[room]/+page.svelte
@@ -18,6 +18,7 @@
   import PageBar from "@lib/components/PageBar.svelte"
   import Divider from "@lib/components/Divider.svelte"
   import MenuSpaceButton from "@app/components/MenuSpaceButton.svelte"
+  import ChannelName from "@app/components/ChannelName.svelte"
   import ChannelMessage from "@app/components/ChannelMessage.svelte"
   import ChannelCompose from "@app/components/ChannelCompose.svelte"
   import {
@@ -30,7 +31,6 @@
     tagRoom,
     MESSAGE,
     getMembershipRoomsByUrl,
-    displayRoom,
   } from "@app/state"
   import {setChecked} from "@app/notifications"
   import {addRoomMembership, removeRoomMembership, subscribePersistent} from "@app/commands"
@@ -135,7 +135,9 @@
     <div slot="icon" class="center">
       <Icon icon="hashtag" />
     </div>
-    <strong slot="title">{displayRoom(room)}</strong>
+    <strong slot="title">
+      <ChannelName {url} {room} />
+    </strong>
     <div slot="action" class="row-2">
       {#if room !== GENERAL}
         {#if getMembershipRoomsByUrl(url, $userMembership).includes(room)}