Matt Lorentz mplorentz
mplorentz commented on pull request coracle/flotilla#93 2026-03-09 14:52:04 +00:00
feature/23-voice-room/poc

I don't love the labels I landed on but see what you think of the current take: "Your Rooms" { favorited voice and text} "Other Rooms" { text rooms} Voice Rooms { voice rooms}

Or when the…

mplorentz pushed to feature/23-voice-room/poc at coracle/flotilla 2026-03-09 14:45:47 +00:00
8a379d36ee Use if let
mplorentz commented on pull request coracle/flotilla#93 2026-03-09 14:45:36 +00:00
feature/23-voice-room/poc

It is harder to read at first glance but ifLet brings warm feelings from better programming languages so it's done.

mplorentz pushed to feature/23-voice-room/poc at coracle/flotilla 2026-03-09 14:43:02 +00:00
aaaa94d28b use new livekit welshman properties
mplorentz pushed to feature/23-voice-room/poc at coracle/flotilla 2026-03-06 21:37:21 +00:00
f1ca9f650a Allow joining without a microphone
mplorentz pushed to feature/23-voice-room/poc at coracle/flotilla 2026-03-06 21:01:15 +00:00
2656ef4dd0 Log join errors
mplorentz commented on pull request coracle/flotilla#93 2026-03-06 16:02:20 +00:00
feature/23-voice-room/poc

I tried that, but realized that you could then join a call on desktop web, resize your browser to be small and then lose a way to join the call. As I type it out I realize that's too edgy of a…

mplorentz pushed to feature/23-voice-room/poc at coracle/flotilla 2026-03-06 16:00:37 +00:00
b7ddd30d10 include room participants inside VoiceRoomItem border
mplorentz commented on pull request coracle/flotilla#93 2026-03-06 14:11:55 +00:00
feature/23-voice-room/poc

Also, you mentioned your bespoke relay has livekit support, is it using welshman? If so, is that something that we could PR to upstream?

I don't have a bespoke relay, I just modified zooid.…

mplorentz pushed to feature/23-voice-room/poc at coracle/flotilla 2026-03-05 21:55:13 +00:00
7680de725a Don't show technical error message to the user
d836fd7b44 Revert changes to dockerfile
Compare 2 commits »
mplorentz pushed to feature/23-voice-room/poc at coracle/flotilla 2026-03-05 21:49:54 +00:00
f68245abe6 Address remaining PR comments
mplorentz commented on pull request coracle/flotilla#93 2026-03-05 21:49:43 +00:00
feature/23-voice-room/poc

I tried this several different ways. I think it turned out ok but I added some util functions. Let me know what you think.

mplorentz commented on pull request coracle/flotilla#93 2026-03-05 21:48:51 +00:00
feature/23-voice-room/poc

@hodlbod I think I have addressed all PR comments, this is ready for another look.

I started adding a feature flag but realized that with the changes to the room form (hiding room type unless…

mplorentz commented on pull request coracle/flotilla#93 2026-03-05 16:18:42 +00:00
feature/23-voice-room/poc

haha, yes. Sorry I did do a self-review of this code but clearly I missed this function or my eyes glazed over while reading it. Cleaning it up.

mplorentz commented on pull request coracle/flotilla#93 2026-03-05 15:34:34 +00:00
feature/23-voice-room/poc

Oh interesting, `e.message

mplorentz commented on pull request coracle/flotilla#93 2026-03-05 15:30:05 +00:00
feature/23-voice-room/poc

Idk maybe it is stupid to think that some library would throw some random object with a message property, but anything seems possible when node_modules are involved 😓

mplorentz commented on pull request coracle/flotilla#93 2026-03-05 15:26:49 +00:00
feature/23-voice-room/poc

I am cleaning this up but I want to fully understand you. Can you explain how this causes bugs? As a non-javascript guy this doesn't look pretty but makes sense to me because e could literally…

mplorentz pushed to feature/23-voice-room/poc at coracle/flotilla 2026-03-05 15:12:56 +00:00
5b887d1329 Use TrustedEvent
4f192f0c08 Use bell icon for notifications
Compare 2 commits »
mplorentz commented on pull request coracle/flotilla#93 2026-03-05 15:09:43 +00:00
feature/23-voice-room/poc

Oh yes that's my mistake. How about we use a bell icon for notifications and speaker icon for voice rooms?

mplorentz commented on pull request coracle/flotilla#93 2026-03-05 15:00:16 +00:00
feature/23-voice-room/poc

Sorry, I'm asking why you suggested (event: Maybe<TrustedEvent>) over (event?: TrustedEvent)?