- https://www.adityaworks.tech
-
- LFX @headlamp
- Javascript Code Repo Expert (Contract) @HackerRank
- R&D Intern @Samsung
- Software Engineer @Tile10
- Joined on
2026-04-03
LGTM, is this still a WIP or ready to merge?
was just checking everything from my side, removing WIP if the changes looks good to you.
Re: tests, it's totally up to you, but I generally go without until the app is stable, then add them with the correct behavior so that I'm not slowing myself down maintaining incorrect tests.…
What would you think about adding a new "delinquent" status instead of deactivation_source? It would keep the code simpler and would be more adaptive to future behavior (it would make sense to…
I’ll push all the updates shortly, including PRs for the other open issues as well.
Thanks, was testing everything end-to-end on my side and removed the WIP label.
Addressed the feedback, and also added tests to cover the flow.
Yes, thought of not raising an issue, but still did to know your thoughts on it.