coracle/caravel
1
1
Fork 2
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: silent NWC auto-payment failure messaging in invoice.created fallback #46

Merged
hodlbod merged 1 commits from userAdityaa/caravel:silent-failure into master 2026-04-23 16:09:51 +00:00
Conversation 0 Commits 1 Files Changed 1
+41 -11
userAdityaa commented 2026-04-23 13:43:59 +00:00
Contributor
Copy Link
Copy Source

Summary

This PR fixes issue #38 where NWC auto-payment failures were saved internally but users only received a generic manual-payment DM.
Now the fallback DM includes a short sanitized NWC failure reason, while the full error is still stored in tenant.nwc_error.

Problem

When NWC auto-payment failed in invoice.created, the system set tenant.nwc_error but did not expose the failure context in the user DM.

What changed

  • Updated invoice.created handling to carry NWC failure context into the fallback DM.
  • Kept existing behavior of storing the full failure in tenant.nwc_error.
  • Added concise warning logging for failed NWC auto-payment attempts.
### Summary This PR fixes issue #38 where NWC auto-payment failures were saved internally but users only received a generic manual-payment DM. Now the fallback DM includes a short sanitized NWC failure reason, while the full error is still stored in `tenant.nwc_error`. ### Problem When NWC auto-payment failed in `invoice.created`, the system set `tenant.nwc_error` but did not expose the failure context in the user DM. ### What changed * Updated `invoice.created` handling to carry NWC failure context into the fallback DM. * Kept existing behavior of storing the full failure in `tenant.nwc_error`. * Added concise warning logging for failed NWC auto-payment attempts.
hodlbod added 1 commit 2026-04-23 16:09:45 +00:00
fix: silent NWC auto-payment failure messaging in invoice.created fallback 45ffee16ef
hodlbod force-pushed silent-failure from 427ef7c86c to 45ffee16ef 2026-04-23 16:09:45 +00:00 Compare
hodlbod merged commit 1aeb15971d into master 2026-04-23 16:09:51 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/caravel#46
Delete Branch "userAdityaa/caravel:silent-failure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?