Refine toast #137
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
From #133
@0xNaman, do you have any opinions about this approach?
That approach makes sense to me. Removing the x button solves the ambiguity I ran into, and auto-dismiss with swipe-to-dismiss feels like the right default. It also matches how most mobile users expect toasts to work.
Moving it to the top on mobile is a good call, right now it competes with the bottom nav. On desktop, I think top right would probably work since that is where most web apps like Slack, Discord put their notifications.
One other thing to consider "Sending..Cancel" toast specifically, If x, cancel button is removed on that one, the user loses the ability to cancel mid-send. Maybe confirmations auto-fade after a couple seconds, but action toasts like sending stay visible until the action completes?
We'll keep the cancel button, but not the x. Or maybe we could reposition it to the top-right of the toast so it's clear what it is. Toast generally does auto-dismiss, but certain ones (like the cancel one) persist until complete.
Hey, since this was initially marked as design-first to confirm the approach and is now moved to dev, I’ve self-assigned it and opened PR #148. If there’s any feedback regarding the design or adjustments needed, please let me know.