Profile name isn't set via onboarding #201
No Assignees
priyanshu_bharti
priyanshu_bharti
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coracle/flotilla#201
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is sort of sporadic, but seems to be the case. The event gets created, but isn't published. I did this to protect new users' privacy — the idea is that profiles only get published to the spaces they join. It's weak privacy protection, and probably isn't worth doing, but this should work. Anyway, make sure there aren't any empty profiles for new signups.
Hi @hodlbod,
I want to take up issue #201 (Profile name isn't set via onboarding).
Please assign it to me.
I'll check the onboarding process and fix the profile name publishing.
Thanks!
hii @hodlbod
can You take a look at this video;
if everything looks good, I'll push the PR.
thanku
So this isn't actually the bug at issue here, it's more that user names don't always show up. Below is a video of the flow, but in this case it happened to work. It may have something to do with either sending or receiving, relay selections, etc. It's very sporadic, so I can't give much more detail than that.
Hi @hodlbod,
While working on #201 (Profile name isn't set via onboarding),
I found one more related issue:
New bug:
Users can create a new account even if they leave the Nickname field completely empty (or just press space and continue). No validation is there, so profile name remains blank.
Should I fix this as part of the same issue #201 (add "Nickname cannot be empty" validation + proper profile name publishing during onboarding)?
Or do you want me to create a separate issue for the validation part?
Let me know how i'd like to proceed.
Thanks!
No, empty names are acceptable, there's nothing we can do to prevent people from publishing weird metadata events from a different client.
@hodlbod Okay, but I still don’t understand the original issue with profile names. Could you please explain it in more detail?
Sometimes, even if the user does provide a username, their profile event doesn't end up getting fetched. This is probably a matter of relay selections — on signup we don't send the profile anywhere (see initProfile). When the user joins a space, we send their profile to the space (see SpaceJoin,
broadcastUserData). There's also a toggle on the profile form that controls whether we broadcast users' profiles. I did this for privacy reasons, but the effect is the profile event sometimes gets lost in the shuffle.