coracle/flotilla
1
3
Fork 9
Code Issues 32 Pull Requests 4 Actions Packages Projects 5 Releases Wiki Activity

Fix deleted rooms persisting in navigation #285

Merged
hodlbod merged 1 commits from userAdityaa/flotilla:fix-room-delete-nav into dev 2026-05-29 15:20:22 +00:00
Conversation 4 Commits 1 Files Changed 2
+7 -3
userAdityaa commented 2026-05-26 07:35:34 +00:00
Collaborator
Copy Link
Copy Source

Summary

  • Fix room deletion not removing the room from the sidebar, even after refresh
  • The timestamp comparison used gt (strictly greater than) — when the ROOM_DELETE event has the same created_at as the ROOM_META, the room survived the filter. Switched to gte.
  • Also fetch ROOM_DELETE events in loadRoom so direct navigation to a deleted room picks up the deletion.

closes #194

### Summary - Fix room deletion not removing the room from the sidebar, even after refresh - The timestamp comparison used `gt` (strictly greater than) — when the `ROOM_DELETE` event has the same `created_at` as the `ROOM_META`, the room survived the filter. Switched to `gte`. - Also fetch `ROOM_DELETE` events in `loadRoom` so direct navigation to a deleted room picks up the deletion. <video src="attachments/38062e6c-3fba-450a-984c-2dc6c760e803" title="Screen Recording 2026-05-26 at 1.15.28 PM.mp4" controls></video> closes #194
Screen Recording 2026-05-26 at 1.15.28 PM.mp4
744 KiB
userAdityaa force-pushed fix-room-delete-nav from 3d9898f6b2 to 55137237b5 2026-05-26 07:37:06 +00:00 Compare
userAdityaa force-pushed fix-room-delete-nav from 55137237b5 to b42ba377e5 2026-05-26 07:47:36 +00:00 Compare
hodlbod reviewed 2026-05-26 15:53:48 +00:00
src/app/core/state.ts Outdated
@@ -597,2 +597,4 @@
Boolean(relay?.supported_nips?.map?.(String)?.includes?.("29"))
const getRoomDeleteId = (event: TrustedEvent) =>
getTagValue("h", event.tags) || getTagValue("d", event.tags)
hodlbod commented 2026-05-26 15:51:30 +00:00
Owner
Copy Link
Copy Source

The d tag will never match, room delete always uses h

The `d` tag will never match, room delete always uses `h`
src/app/core/state.ts Outdated
@@ -608,0 +618,4 @@
if (h) {
deletedByH.set(h, max([deletedByH.get(h), event.created_at]))
}
}
hodlbod commented 2026-05-26 15:52:52 +00:00
Owner
Copy Link
Copy Source

this is unnecessary, deletes are already in roomMetaEventsByUrl right?

this is unnecessary, deletes are already in roomMetaEventsByUrl right?
userAdityaa commented 2026-05-27 15:28:15 +00:00
Author
Collaborator
Copy Link
Copy Source

It’s already there, but after deleting a room and refreshing, the deletion took a second to reflect.

so I did this to avoid the user noticing that delay even for a moment.
let me attach a video for it.

It’s already there, but after deleting a room and refreshing, the deletion took a second to reflect. so I did this to avoid the user noticing that delay even for a moment. let me attach a video for it.
hodlbod commented 2026-05-27 17:46:14 +00:00
Owner
Copy Link
Copy Source

I see, the roomMetaEventsByIdByUrl isn't populated until the event is accepted by the relay? This should be something taken care of by welshman's thunk — it populates both repository and tracker optimistically when publishing. I would debug why that's not working rather than add this band-aid.

I see, the roomMetaEventsByIdByUrl isn't populated until the event is accepted by the relay? This should be something taken care of by welshman's thunk — it populates both repository and tracker optimistically when publishing. I would debug why that's not working rather than add this band-aid.
userAdityaa commented 2026-05-27 18:01:47 +00:00
Author
Collaborator
Copy Link
Copy Source

please focus on caravel from your side for now since it’s the priority. I’ll dig into this issue a bit more from my end.

please focus on caravel from your side for now since it’s the priority. I’ll dig into this issue a bit more from my end.
👍 1
hodlbod reviewed 2026-05-27 17:46:30 +00:00
hodlbod left a comment
Owner
Copy Link
Copy Source

See review comments

See review comments
👍 1
userAdityaa force-pushed fix-room-delete-nav from b42ba377e5 to 92cc000004 2026-05-28 09:57:08 +00:00 Compare
hodlbod reviewed 2026-05-28 22:28:09 +00:00
src/app/core/state.ts Outdated
@@ -611,3 +613,3 @@
for (const event of deleteEvents) {
for (const h of getTagValues("h", event.tags)) {
const h = getRoomDeleteId(event)
hodlbod commented 2026-05-28 22:27:39 +00:00
Owner
Copy Link
Copy Source

Just leave getTagValues, getRoomDeleteId is unnecessary if you understand the data model

Just leave getTagValues, getRoomDeleteId is unnecessary if you understand the data model
👍 1
src/app/core/state.ts Outdated
@@ -654,1 +658,3 @@
filters: [{kinds: [ROOM_META], "#d": [h]}],
filters: [
{kinds: [ROOM_META], "#d": [h]},
{kinds: [ROOM_DELETE], "#h": [h]},
hodlbod commented 2026-05-28 22:28:06 +00:00
Owner
Copy Link
Copy Source

It looks like this is the only substantial change, does this fix it on its own?

It looks like this is the only substantial change, does this fix it on its own?
userAdityaa commented 2026-05-29 06:36:25 +00:00
Author
Collaborator
Copy Link
Copy Source

It looks like this is the only substantial change, does this fix it on its own?

It seems to be fixed now. Could you please confirm from your side as well?

> It looks like this is the only substantial change, does this fix it on its own? It seems to be fixed now. Could you please confirm from your side as well?
userAdityaa force-pushed fix-room-delete-nav from 92cc000004 to 4c737b26c0 2026-05-29 06:35:32 +00:00 Compare
hodlbod added 1 commit 2026-05-29 15:20:04 +00:00
fix: deleted rooms persisting in navigation 594231ea48
hodlbod force-pushed fix-room-delete-nav from 4c737b26c0 to 594231ea48 2026-05-29 15:20:04 +00:00 Compare
hodlbod commented 2026-05-29 15:20:15 +00:00
Owner
Copy Link
Copy Source

Looks good to me

Looks good to me
hodlbod merged commit 152d35f92a into dev 2026-05-29 15:20:22 +00:00
hodlbod deleted branch fix-room-delete-nav 2026-05-29 15:20:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
hodlbod
Labels
Clear labels
design
For issues related to design work. Development should be done in another issue and refer back to this one.
 dev
Issues related to development work
 easy
Issues that can be executed on by new contributors
 idea
For issues that aren't yet actionable
 priority
For issues related to high priority features and bugs
 usability
Issues that have to be validated with real live human beings.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
AQB hodlbod (hodlbod) mplorentz (Matt Lorentz) sakshamjain (Saksham Jain) sondreb triesap userAdityaa (Aditya Chaudhary)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#285
Delete Branch "userAdityaa/flotilla:fix-room-delete-nav"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?