coracle/flotilla
1
6
Fork 23
Code Issues 42 Pull Requests 2 Actions Packages Projects 5 Releases Wiki Activity

join-approval #103

Merged
hodlbod merged 2 commits from join-approval into dev 2026-03-19 15:40:35 +00:00
Conversation 3 Commits 2 Files Changed 15
+326 -115
hodlbod commented 2026-03-18 23:14:29 +00:00
Owner
Copy Link
Copy Source

Fixes #30

Fixes #30
hodlbod added 1 commit 2026-03-18 23:14:29 +00:00
Update closed room behavior 7c9b191bdd
hodlbod requested review from mplorentz 2026-03-18 23:14:29 +00:00
mplorentz reviewed 2026-03-19 14:49:27 +00:00
mplorentz left a comment
Collaborator
Copy Link
Copy Source

This looks awesome but I had some problems testing it. I created a new room on relay.scuttle.works and checked the new "Require admins to approve join requests" box, but then when I tried to make a join request from a non-admin account it just let me join the room without approval and post. Are there zooid changes required to support this flotilla branch?

This looks awesome but I had some problems testing it. I created a new room on relay.scuttle.works and checked the new "Require admins to approve join requests" box, but then when I tried to make a join request from a non-admin account it just let me join the room without approval and post. Are there zooid changes required to support this flotilla branch?
src/app/components/RoomForm.svelte Outdated
@@ -209,3 +209,3 @@
<div class="flex items-center gap-2">
<input type="checkbox" class="checkbox" bind:checked={values.isClosed} />
<span class="text-sm opacity-75">Ignore requests to join</span>
<span class="text-sm opacity-75">Require admins to approve join requests</span>
mplorentz commented 2026-03-19 14:41:08 +00:00
Collaborator
Copy Link
Copy Source

It seems slightly ambiguous what's going to happen if this box is unchecked. Can any member approve join requests? Are they approved automatically? I'm having trouble coming up with a better phrase though. Maybe something like "Membership requires approval" since all the other boxes here reference membership. Another option would be to change it to a select box labeled something like:

Room Membership: 
- anyone can join
- require admin approval
It seems slightly ambiguous what's going to happen if this box is unchecked. Can any member approve join requests? Are they approved automatically? I'm having trouble coming up with a better phrase though. Maybe something like "Membership requires approval" since all the other boxes here reference membership. Another option would be to change it to a select box labeled something like: ``` Room Membership: - anyone can join - require admin approval ```
hodlbod commented 2026-03-19 15:40:15 +00:00
Author
Owner
Copy Link
Copy Source

Good suggestion, I think this form could be nuanced down the road too (e.g. if membership doesn't restrict read/write then it should auto-approve; if read/write aren't gated it doesn't make sense to make the room unlisted, etc).

Good suggestion, I think this form could be nuanced down the road too (e.g. if membership doesn't restrict read/write then it should auto-approve; if read/write aren't gated it doesn't make sense to make the room unlisted, etc).
hodlbod force-pushed join-approval from f9d2093a84 to b100ec124c 2026-03-19 15:34:16 +00:00 Compare
hodlbod commented 2026-03-19 15:39:22 +00:00
Author
Owner
Copy Link
Copy Source

This looks awesome but I had some problems testing it. I created a new room on relay.scuttle.works and checked the new "Require admins to approve join requests" box, but then when I tried to make a join request from a non-admin account it just let me join the room without approval and post.

Did you also check "Only allow members to send messages"? If that and the read setting aren't enabled then membership is a no-op.

Are there zooid changes required to support this flotilla branch?

Yeah, there's a new commit that only auto-approves when the room is not closed, which is probably what you were seeing.

> This looks awesome but I had some problems testing it. I created a new room on relay.scuttle.works and checked the new "Require admins to approve join requests" box, but then when I tried to make a join request from a non-admin account it just let me join the room without approval and post. Did you also check "Only allow members to send messages"? If that and the read setting aren't enabled then membership is a no-op. > Are there zooid changes required to support this flotilla branch? Yeah, there's a new commit that only auto-approves when the room is not closed, which is probably what you were seeing.
hodlbod merged commit 1f5be54cb1 into dev 2026-03-19 15:40:35 +00:00
hodlbod deleted branch join-approval 2026-03-19 15:40:35 +00:00
mplorentz commented 2026-03-25 18:10:34 +00:00
Collaborator
Copy Link
Copy Source

Did you also check "Only allow members to send messages"? If that and the read setting aren't enabled then membership is a no-op.

Yes I did check that box. I tested again today on the latest branches of flotilla and zooid and it seems to work!

> Did you also check "Only allow members to send messages"? If that and the read setting aren't enabled then membership is a no-op. Yes I did check that box. I tested again today on the latest branches of flotilla and zooid and it seems to work!
Sign in to join this conversation.
Reviewers
No Reviewers
mplorentz
Labels
Clear labels
design
For issues related to design work. Development should be done in another issue and refer back to this one.
 dev
Issues related to development work
 easy
Issues that can be executed on by new contributors
 idea
For issues that aren't yet actionable
 priority
For issues related to high priority features and bugs
 usability
Issues that have to be validated with real live human beings.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod) mplorentz (Matt Lorentz) sakshamjain (Saksham Jain) sondreb triesap userAdityaa (Aditya Chaudhary)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#103
Delete Branch "join-approval"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?