coracle/flotilla
1
6
Fork 23
Code Issues 42 Pull Requests 2 Actions Packages Projects 5 Releases Wiki Activity

Fix error toast when failing to join room. #113

Merged
hodlbod merged 2 commits from bugfix/error-toast-on-room-join into dev 2026-04-02 19:35:46 +00:00
Conversation 1 Commits 2 Files Changed 1
+13 -1
mplorentz commented 2026-04-01 20:45:43 +00:00
Collaborator
Copy Link
Copy Source

The handleJoinError function got removed in #109... I'm confused how that happened because I think one of us would have caught it. I think I probably messed up a merge conflict while rebasing, but it's impossible to tell now. (Rewriting git history all the time stresses me out)

The `handleJoinError` function got removed in https://gitea.coracle.social/coracle/flotilla/pulls/109... I'm confused how that happened because I think one of us would have caught it. I think I probably messed up a merge conflict while rebasing, but it's impossible to tell now. (Rewriting git history all the time stresses me out)
hodlbod reviewed 2026-04-01 21:08:46 +00:00
src/app/components/VoiceRoomJoinDialog.svelte Outdated
@@ -48,0 +55,4 @@
message = "Connection timed out. Please check your network and try again."
else if (e instanceof Error) message = e.message
pushToast({theme: "error", message})
}
hodlbod commented 2026-04-01 21:08:46 +00:00
Owner
Copy Link
Copy Source

ok but no-bracket elses are asking for trouble

ok but no-bracket elses are asking for trouble
👍 1
mplorentz requested review from hodlbod 2026-04-02 19:30:51 +00:00
hodlbod added 2 commits 2026-04-02 19:35:37 +00:00
Fix error toast when failing to join room. c3441981c5
Move handleJoinerror into VoiceRoomJoinDialog. d70391905a
hodlbod force-pushed bugfix/error-toast-on-room-join from a731d0f3a3 to d70391905a 2026-04-02 19:35:37 +00:00 Compare
hodlbod merged commit c5fcf12165 into dev 2026-04-02 19:35:46 +00:00
hodlbod deleted branch bugfix/error-toast-on-room-join 2026-04-02 19:35:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
hodlbod
Labels
Clear labels
design
For issues related to design work. Development should be done in another issue and refer back to this one.
 dev
Issues related to development work
 easy
Issues that can be executed on by new contributors
 idea
For issues that aren't yet actionable
 priority
For issues related to high priority features and bugs
 usability
Issues that have to be validated with real live human beings.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod) mplorentz (Matt Lorentz) sakshamjain (Saksham Jain) sondreb triesap userAdityaa (Aditya Chaudhary)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#113
Delete Branch "bugfix/error-toast-on-room-join"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?