coracle/flotilla
1
6
Fork 24
Code Issues 42 Pull Requests 2 Actions Packages Projects 5 Releases Wiki Activity

keep secondary nav visible on compact landscape screens #146

Closed
nayan9617 wants to merge 1 commits from nayan9617/flotilla:fix/landscape-secondary-nav into dev
pull from: nayan9617/flotilla:fix/landscape-secondary-nav
merge into: coracle:dev
Conversation 3 Commits 1 Files Changed 2
+15 -1
nayan9617 commented 2026-04-03 19:00:18 +00:00
Contributor
Copy Link
Copy Source

Summary

This PR improves the Android landscape layout without hiding the secondary nav. The issue was that touch devices in landscape were switching into a desktop-style layout too early, which left page content squeezed or offset incorrectly.

Addressing extended version of issue #117

What changed

-Kept the secondary nav visible in compact landscape.
-Hid only the desktop primary rail on touch landscape screens.
-Adjusted the page width/offset utilities so content uses the remaining available space correctly.

Why

The breakpoint behavior was fine in desktop browsers, but on Android it caused the app to behave like a desktop layout even when the screen was still effectively mobile. This approach keeps the navigation visible while fixing the content sizing at the layout level.

## Summary This PR improves the Android landscape layout without hiding the secondary nav. The issue was that touch devices in landscape were switching into a desktop-style layout too early, which left page content squeezed or offset incorrectly. Addressing extended version of issue #117 ## What changed -Kept the secondary nav visible in compact landscape. -Hid only the desktop primary rail on touch landscape screens. -Adjusted the page width/offset utilities so content uses the remaining available space correctly. ## Why The breakpoint behavior was fine in desktop browsers, but on Android it caused the app to behave like a desktop layout even when the screen was still effectively mobile. This approach keeps the navigation visible while fixing the content sizing at the layout level.
nayan9617 added 1 commit 2026-04-03 19:00:18 +00:00
keep secondary nav visible on compact landscape screens bd9336c8c7
hodlbod commented 2026-04-03 22:25:08 +00:00
Owner
Copy Link
Copy Source

We can't remove the primary nav, that leaves people stranded on certain pages with no way back. Can you explain why the breakpoint was working differently on mobile? I'm fine with any given screen being less than or greater than the md breakpoint, but this appears to be both at once.

We can't remove the primary nav, that leaves people stranded on certain pages with no way back. Can you explain why the breakpoint was working differently on mobile? I'm fine with any given screen being less than or greater than the `md` breakpoint, but this appears to be both at once.
hodlbod commented 2026-04-04 00:17:39 +00:00
Owner
Copy Link
Copy Source

Ok, this ended up being much more involved than I was expecting. Apparently fixed positioning is squirrely on android, so I moved everything to relative positioning. See 9311cab3 if you're interested in how I implemented it.

Ok, this ended up being much more involved than I was expecting. Apparently fixed positioning is squirrely on android, so I moved everything to relative positioning. See 9311cab3 if you're interested in how I implemented it.
hodlbod closed this pull request 2026-04-04 00:17:39 +00:00
nayan9617 commented 2026-04-04 06:06:13 +00:00
Author
Contributor
Copy Link
Copy Source

I reviewed your approach, thanks for the clarification! will sync to latest dev.

I reviewed your approach, thanks for the clarification! will sync to latest dev.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
design
For issues related to design work. Development should be done in another issue and refer back to this one.
 dev
Issues related to development work
 easy
Issues that can be executed on by new contributors
 idea
For issues that aren't yet actionable
 priority
For issues related to high priority features and bugs
 usability
Issues that have to be validated with real live human beings.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod) mplorentz (Matt Lorentz) sakshamjain (Saksham Jain) sondreb triesap userAdityaa (Aditya Chaudhary)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#146
Delete Branch "nayan9617/flotilla:fix/landscape-secondary-nav"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?