Clean up drafts implementation #164

2026-04-07T13:02:16Z

hodlbod commented

2026-04-07 13:02:16 +00:00

No description provided.

hodlbod added 1 commit 2026-04-07 13:02:16 +00:00

Clean up drafts implementation 99734dec25

hodlbod reviewed 2026-04-07 13:05:30 +00:00

src/app/components/CalendarEventForm.svelte

						
				@@ -43,4 +43,2 @@

				  let {url, h, header, initialValues}: Props = $props()

				  const draftKey = new DraftKey<CalendarValues>(`calendar:${url}:${h ?? ""}`)

				  const draft = draftKey.get()

hodlbod commented

2026-04-07 13:03:20 +00:00

No need to clutter things with one-off variables

👍 1

src/app/components/CalendarEventForm.svelte

						
				@@ -32,2 +32,2 @@

				    start: number | undefined

				    end: number | undefined

				    start?: number

				    end?: number

hodlbod commented

2026-04-07 13:02:59 +00:00

In my review I didn't realize that these had no default values, and so we have to accept optional/undefined.

👍 1

src/app/components/CalendarEventForm.svelte

						
				@@ -129,1 +116,4 @@

				  let endDirty = $state(Boolean(initialValues?.end))

				  let content = $state(initialValues?.content ?? "")

				  const onChange = (json: object) => {

hodlbod commented

2026-04-07 13:03:39 +00:00

Avoid unknown; object isn't much better but it is marginally better.

👍 1

src/app/components/ClassifiedForm.svelte

						
				@@ -51,4 +46,0 @@

				    images?: (string | File)[]

				    status?: string

				    topics?: string[]

				  }

hodlbod commented

2026-04-07 13:04:24 +00:00

This is what I meant by creating the additional type, this allows us to name types but avoid duplicating the definitions.

👍 1

src/app/editor/index.ts

						
				@@ -148,7 +145,5 @@ export const makeEditor = async ({

				    },

				  })

				  ;(ed as any)._shouldAutofocus = autofocus

hodlbod commented

2026-04-07 13:05:23 +00:00

This is a hack; we can just pass the thing straight to EditorCompose

👍 1

hodlbod commented

2026-04-07 13:06:24 +00:00

@userAdityaa this PR is a follow up from #155, just a few things that I thought it would be easier to show rather than tell. Just take a look to get an idea of what I was going for.

👍 1

hodlbod merged commit 17fb4e780b into dev

2026-04-07 13:06:30 +00:00

hodlbod deleted branch drafts-cleanup

2026-04-07 13:06:31 +00:00

hodlbod referenced this issue from a commit

2026-04-07 13:06:32 +00:00

Clean up drafts implementation (#164)

userAdityaa commented

2026-04-07 17:07:11 +00:00

@userAdityaa this PR is a follow up from #155, just a few things that I thought it would be easier to show rather than tell. Just take a look to get an idea of what I was going for.

Thanks for the review and the fixes! Noted the suggestions, will incorporate these improvements in future PRs.

> @userAdityaa this PR is a follow up from #155, just a few things that I thought it would be easier to show rather than tell. Just take a look to get an idea of what I was going for. Thanks for the review and the fixes! Noted the suggestions, will incorporate these improvements in future PRs.

👍 1

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coracle/flotilla#164