Page titles (#16) #62

2026-02-17T19:10:55Z

triesap commented

Closes #16

triesap added 1 commit 2026-02-17 19:10:56 +00:00

hodlbod requested changes 2026-02-17 19:20:37 +00:00

hodlbod left a comment

Just a couple things

						
				@@ -0,0 +83,4 @@

				  }

				  const url = decodeRelay(relay)

				  const filters: Filter[] = [{ids: [eventId], limit: 1}]

hodlbod commented

This won't work if eventId is an address, try getIdFilters

This won't work if eventId is an address, try `getIdFilters`

hodlbod commented

Or, better yet, just do repository.getEvent(id || address)

Or, better yet, just do `repository.getEvent(id || address)`

src/routes/+layout.svelte Outdated

						
				@@ -201,1 +207,4 @@

				  })

				  $effect(() => {

				    if (typeof document !== "undefined") {

hodlbod commented

Do we need this check? I mean, we're using adapter-static. We could also probably just inline the pageTitle instead of adding an additional derived.

triesap added 1 commit 2026-02-17 20:19:26 +00:00

hodlbod merged commit a996664e6c into dev

2026-02-17 20:39:08 +00:00

hodlbod referenced this issue from a commit

hodlbod referenced this issue from a commit

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coracle/flotilla#62