coracle/flotilla
1
6
Fork 24
Code Issues 42 Pull Requests 2 Actions Packages Projects 5 Releases Wiki Activity

Fix wallet status when wallet is unreachable (#79) #80

Closed
triesap wants to merge 33 commits from fix/79-wallet-status-unavailable into dev
pull from: fix/79-wallet-status-unavailable
merge into: coracle:dev
Conversation 2 Commits 33 Files Changed 45
+103 -29
triesap commented 2026-02-18 23:08:52 +00:00
Collaborator
Copy Link
Copy Source

Closes #79

Closes #79
triesap added 3 commits 2026-02-18 23:08:52 +00:00
Fix wallet status when wallet is unreachable 53d2893b8a
Add wallet status retry and WebLN probe e24d51310e
Remove wallet status retry a58e930216
hodlbod requested changes 2026-02-18 23:16:19 +00:00
src/routes/settings/wallet/+page.svelte
@@ -43,0 +60,4 @@
const checkNwcStatus = async () => {
try {
await withTimeout(getNwcClient().getInfo(), 5000)
hodlbod commented 2026-02-18 23:12:31 +00:00
Owner
Copy Link
Copy Source

Just do const ok = await Promise.race(getNwcClient().getInfo().then(always("connected")), sleep(5000).then(always("unavailable"))). Replaces 40 lines of code with 4, and it's much easier to follow.

Just do `const ok = await Promise.race(getNwcClient().getInfo().then(always("connected")), sleep(5000).then(always("unavailable")))`. Replaces 40 lines of code with 4, and it's much easier to follow.
hodlbod marked this conversation as resolved
src/routes/settings/wallet/+page.svelte Outdated
@@ -43,0 +112,4 @@
if (requestId === walletStatusRequestId) {
walletStatus = nextStatus
}
})()
hodlbod commented 2026-02-18 23:14:17 +00:00
Owner
Copy Link
Copy Source

A nice little helper for this pattern is the call function. It's just a little prettier.

A nice little helper for this pattern is the `call` function. It's just a little prettier.
triesap added 1 commit 2026-02-19 00:44:48 +00:00
Simplify wallet status probe 39c6a33273
hodlbod commented 2026-02-24 23:46:08 +00:00
Owner
Copy Link
Copy Source

Merged via 6d99e296

Merged via 6d99e296
hodlbod closed this pull request 2026-02-24 23:46:08 +00:00
hodlbod deleted branch fix/79-wallet-status-unavailable 2026-02-24 23:46:11 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
hodlbod
Labels
Clear labels
design
For issues related to design work. Development should be done in another issue and refer back to this one.
 dev
Issues related to development work
 easy
Issues that can be executed on by new contributors
 idea
For issues that aren't yet actionable
 priority
For issues related to high priority features and bugs
 usability
Issues that have to be validated with real live human beings.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hodlbod (hodlbod) mplorentz (Matt Lorentz) sakshamjain (Saksham Jain) sondreb triesap userAdityaa (Aditya Chaudhary)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coracle/flotilla#80
Delete Branch "fix/79-wallet-status-unavailable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?