No, this is a bug. It works in firefox at least, what browser is this?
Cool, looks good enough to move to dev. I would like to see something a little more interesting though, maybe a card that peeks out from under the header.
I think that subtitle should probably not mention keypairs or the protocol at all
Same thing, see if you can adjust the data model so that this use case falls out naturally instead of being shoehorned in.
Lots of copying, this could be much simplified if you can make the data model flow
These types are the place where the most time should be spent on the next revision. These types aren't bad, but I think we could cut probably ~100 LOC by making them cleaner. I don't have time right now to give it the necessary thought though.
Instead of mapping to an ad hoc data type, I would just defer the display logic until it's needed. You could add helper functions if needed.
Since role is a defined data type, I would just pass the whole thing in and RoleBadge can accept a RoleDefinition
Try to re-use defined types when possible. This mostly overlaps with RoleDefinition.
This whole thing could probably go in the roles.ts file. See if you can define types that make sense in this context. The fewer named (and especially ad-hoc) types, the easier the code is to read.
- NIP 43 should probably reference nip 86 methods rather than kind numbers
- Those numbers should be ok, any particular reason not to use them?
- It's hard to say what should be nip 86 and what…